LibJS: Make define_property always throw if specified

Now put uses is_strict_mode to determine define_property should throw
Author: https://github.com/davidot Commit: 15edad8202 Pull-request: https://github.com/SerenityOS/serenity/pull/8191
2025-09-12 12:32:21 +00:00 · 2021-06-21 16:32:07 +02:00 · 2021-06-21 16:32:07 +02:00 · 15edad8202 · 2024-07-18 11:39:31 +09:00
commit 15edad8202
parent e10219a293
2 changed files with 4 additions and 5 deletions
--- a/Userland/Libraries/LibJS/Tests/builtins/Array/Array.prototype.shift.js
+++ b/Userland/Libraries/LibJS/Tests/builtins/Array/Array.prototype.shift.js
@ -26,7 +26,7 @@ test("Issue #5884, GenericIndexedPropertyStorage::take_first() loses elements",
    const a = [];
    for (let i = 0; i < 300; i++) {
        // NOTE: We use defineProperty to prevent the array from using SimpleIndexedPropertyStorage
-        Object.defineProperty(a, i, { value: i, writable: false });
+        Object.defineProperty(a, i, { value: i, configurable: true });
    }
    expect(a.length).toBe(300);
    for (let i = 0; i < 300; i++) {