mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-10 01:59:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS/Bytecode: Always return false on attempt to delete local variable

Browse source 
Since it is not possible for delete operator to return true when it is
applied to local variable, DeleteVariable can safely always return
false for locals.

This also fixes operators/delete-local-variable.js in test-js.
This commit is contained in:
Aliaksandr Kalenik 2023-07-08 20:29:13 +02:00 • committed by Andreas Kling
commit 167495b87b
Notes: sideshowbarker 2024-07-17 03:16:02 +09:00
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Bytecode/Generator.cpp
View file

@ -298,7 +298,10 @@ CodeGenerationErrorOr<void> Generator::emit_delete_reference(JS::ASTNode const&
{
if (is<Identifier>(node)) {
auto& identifier = static_cast<Identifier const&>(node);
emit<Bytecode::Op::DeleteVariable>(intern_identifier(identifier.string()));
if (identifier.is_local())
emit<Bytecode::Op::LoadImmediate>(Value(false));
else
emit<Bytecode::Op::DeleteVariable>(intern_identifier(identifier.string()));
return {};
}