mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-07-29 04:09:13 +00:00
LibWeb: Implement HTMLFrameElement as a NavigableContainer
NavigableContainer is our home grown concept which already contains the AOs needed for frame and iframe elements. This patch simply aligns our HTMLFrameElement implementation with this class. A couple of notes: 1. The <script> in the <head> element is intentional. The <frameset> element effectively takes the place of the <body> element, and we cannot add a <script> to a <frameset> element. 2. We don't render <frameset> or <frame> at all. Rendering is defined in the following spec: https://html.spec.whatwg.org/multipage/rendering.html#frames-and-framesets 3. If you load the test page in your browser, you won't see anything, regardless of (2). Our test infra adds a <pre> element to the "body" element (which is the <frameset> element here). Such children will never be rendered. In the future, we could come up with something better for our test infra to do, but this isn't important anyways for this test - we can still grab the <pre> element's innerText.
This commit is contained in:
parent
7d3ad89603
commit
16def85153
Notes:
github-actions[bot]
2024-11-04 09:55:47 +00:00
Author: https://github.com/trflynn89
Commit: 16def85153
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2152
Reviewed-by: https://github.com/tcl3 ✅
6 changed files with 103 additions and 6 deletions
|
@ -12,8 +12,8 @@ interface HTMLFrameElement : HTMLElement {
|
|||
[CEReactions, Reflect=frameborder] attribute DOMString frameBorder;
|
||||
[CEReactions, Reflect=longdesc, URL] attribute USVString longDesc;
|
||||
[CEReactions, Reflect=noresize] attribute boolean noResize;
|
||||
[FIXME] readonly attribute Document? contentDocument;
|
||||
[FIXME] readonly attribute WindowProxy? contentWindow;
|
||||
readonly attribute Document? contentDocument;
|
||||
readonly attribute WindowProxy? contentWindow;
|
||||
|
||||
[CEReactions, LegacyNullToEmptyString, Reflect=marginheight] attribute DOMString marginHeight;
|
||||
[CEReactions, LegacyNullToEmptyString, Reflect=marginwidth] attribute DOMString marginWidth;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue