From 171937cc72ff1d5197eb6751876dbc8a13738118 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Tue, 2 Sep 2025 12:44:34 -0400 Subject: [PATCH] LibWebView: Return a ByteString from WebView::url_text_to_copy The result is currently only used as a StringView, but a future commit will place the result in Web::Clipboard::SystemClipboardRepresentation, which requires a ByteString (there's no UTF-8 clipboard requirement). --- Libraries/LibWebView/URL.cpp | 10 ++++------ Libraries/LibWebView/URL.h | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Libraries/LibWebView/URL.cpp b/Libraries/LibWebView/URL.cpp index e176d01730a..251fa4f02a3 100644 --- a/Libraries/LibWebView/URL.cpp +++ b/Libraries/LibWebView/URL.cpp @@ -176,16 +176,14 @@ URLType url_type(URL::URL const& url) return URLType::Other; } -String url_text_to_copy(URL::URL const& url) +ByteString url_text_to_copy(URL::URL const& url) { - auto url_text = url.to_string(); + auto url_text = url.to_byte_string(); if (url.scheme() == "mailto"sv) - return MUST(url_text.substring_from_byte_offset("mailto:"sv.length())); - + return url_text.substring("mailto:"sv.length()); if (url.scheme() == "tel"sv) - return MUST(url_text.substring_from_byte_offset("tel:"sv.length())); - + return url_text.substring("tel:"sv.length()); return url_text; } diff --git a/Libraries/LibWebView/URL.h b/Libraries/LibWebView/URL.h index c5f7884f25b..43723040dc3 100644 --- a/Libraries/LibWebView/URL.h +++ b/Libraries/LibWebView/URL.h @@ -35,6 +35,6 @@ enum class URLType { Other, }; WEBVIEW_API URLType url_type(URL::URL const&); -WEBVIEW_API String url_text_to_copy(URL::URL const&); +WEBVIEW_API ByteString url_text_to_copy(URL::URL const&); }