mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-01 07:52:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibGUI+SoundPlayer: Use 'decrease_slider_by_page_steps()' method

Browse source 
This method allow us to avoid repeating the pattern
'set_value(value() - page_step() * page_number)'.
This commit is contained in:
Elyse 2021-10-31 12:38:15 -06:00 • committed by Andreas Kling
parent 0d660b27ae
commit 173a84a2ef
Notes: sideshowbarker 2024-07-17 21:55:07 +09:00
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/SoundPlayer/SoundPlayerWidgetAdvancedView.cpp
View file

@ -152,7 +152,7 @@ void SoundPlayerWidgetAdvancedView::keydown_event(GUI::KeyEvent& event)
m_volume_slider->increase_slider_by_page_steps(1);
if (event.key() == Key_Down)
m_volume_slider->set_value(m_volume_slider->value() - m_volume_slider->page_step());
m_volume_slider->decrease_slider_by_page_steps(1);
GUI::Widget::keydown_event(event);
}

2
Userland/Libraries/LibGUI/Slider.cpp
View file

@ -106,7 +106,7 @@ void Slider::mousedown_event(MouseEvent& event)
if (mouse_offset > knob_last_edge)
increase_slider_by_page_steps(1);
else if (mouse_offset < knob_first_edge)
set_value(value() - page_step());
decrease_slider_by_page_steps(1);
}
}
return Widget::mousedown_event(event);