mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Fix crash for calculated transition duration/delays

Browse source 
As the parser was trying to directly unwrap an unresolved duration.
Currently we are outputting the wrong results for the serialized
duration, but this is still a step forwards.

Fixes a crash seen on: https://evaparish.com/blog/how-i-edit
This commit is contained in:
Shannon Booth 2024-04-06 14:16:51 +02:00 • committed by Sam Atkins
commit 18520561e7
Notes: sideshowbarker 2024-07-17 05:09:48 +09:00
5 changed files with 24 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -696,8 +696,8 @@ void StyleComputer::for_each_property_expanding_shorthands(PropertyID property_i
Array<Vector<ValueComparingNonnullRefPtr<StyleValue const>>, 4> transition_values;
for (auto const& transition : transitions) {
transition_values[0].append(*transition.property_name);
transition_values[1].append(TimeStyleValue::create(transition.duration));
transition_values[2].append(TimeStyleValue::create(transition.delay));
transition_values[1].append(transition.duration.as_style_value());
transition_values[2].append(transition.delay.as_style_value());
if (transition.easing)
transition_values[3].append(*transition.easing);
}