LibWeb: Implement CookieStore::delete(options)

Author: https://github.com/IdanHo
Commit: 185f8f7d56
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5766
Reviewed-by: https://github.com/trflynn89 ✅

Libraries/LibWeb/CookieStore/CookieStore.cpp

@@ -627,4 +627,48 @@ GC::Ref<WebIDL::Promise> CookieStore::delete_(String name)
     return promise;
 }
 
+// https://cookiestore.spec.whatwg.org/#dom-cookiestore-delete-options
+GC::Ref<WebIDL::Promise> CookieStore::delete_(CookieStoreDeleteOptions const& options)
+{
+    auto& realm = this->realm();
+
+    // 1. Let settings be this’s relevant settings object.
+    auto const& settings = HTML::relevant_settings_object(*this);
+
+    // 2. Let origin be settings’s origin.
+    auto const& origin = settings.origin();
+
+    // 3. If origin is an opaque origin, then return a promise rejected with a "SecurityError" DOMException.
+    if (origin.is_opaque())
+        return WebIDL::create_rejected_promise(realm, WebIDL::SecurityError::create(realm, "Document origin is opaque"_string));
+
+    // 4. Let url be settings’s creation URL.
+    auto url = settings.creation_url;
+
+    // 5. Let p be a new promise.
+    auto promise = WebIDL::create_promise(realm);
+
+    // 6. Run the following steps in parallel:
+    Platform::EventLoopPlugin::the().deferred_invoke(GC::create_function(realm.heap(), [&realm, client = m_client, promise, url = move(url), options = options]() {
+        // 1. Let r be the result of running delete a cookie with url, options["name"], options["domain"], options["path"],
+        //    and options["partitioned"].
+        auto result = delete_a_cookie(client, url, options.name, options.domain, options.path, options.partitioned);
+
+        // AD-HOC: Queue a global task to perform the next steps
+        // Spec issue: https://github.com/whatwg/cookiestore/issues/239
+        queue_global_task(HTML::Task::Source::Unspecified, realm.global_object(), GC::create_function(realm.heap(), [&realm, promise, result]() {
+            HTML::TemporaryExecutionContext execution_context { realm };
+            // 2. If r is failure, then reject p with a TypeError and abort these steps.
+            if (!result)
+                return WebIDL::reject_promise(realm, promise, JS::TypeError::create(realm, "Name is malformed"sv));
+
+            // 3. Resolve p with undefined.
+            WebIDL::resolve_promise(realm, promise);
+        }));
+    }));
+
+    // 7. Return p.
+    return promise;
+}
+
 }

Libraries/LibWeb/CookieStore/CookieStore.h

@@ -37,6 +37,14 @@ struct CookieInit {
     bool partitioned { false };
 };
 
+// https://cookiestore.spec.whatwg.org/#dictdef-cookiestoredeleteoptions
+struct CookieStoreDeleteOptions {
+    String name;
+    Optional<String> domain;
+    String path;
+    bool partitioned { false };
+};
+
 // https://cookiestore.spec.whatwg.org/#cookiestore
 class CookieStore final : public DOM::EventTarget {
     WEB_PLATFORM_OBJECT(CookieStore, DOM::EventTarget);
@@ -53,6 +61,7 @@ public:
     GC::Ref<WebIDL::Promise> set(CookieInit const&);
 
     GC::Ref<WebIDL::Promise> delete_(String name);
+    GC::Ref<WebIDL::Promise> delete_(CookieStoreDeleteOptions const&);
 
 private:
     CookieStore(JS::Realm&, PageClient&);

Libraries/LibWeb/CookieStore/CookieStore.idl

@@ -32,6 +32,13 @@ dictionary CookieInit {
     boolean partitioned = false;
 };
 
+dictionary CookieStoreDeleteOptions {
+    required USVString name;
+    USVString? domain = null;
+    USVString path = "/";
+    boolean partitioned = false;
+};
+
 // https://cookiestore.spec.whatwg.org/#cookiestore
 [Exposed=(ServiceWorker,Window), SecureContext]
 interface CookieStore : EventTarget {
@@ -45,6 +52,7 @@ interface CookieStore : EventTarget {
     Promise<undefined> set(CookieInit options);
 
     Promise<undefined> delete(USVString name);
+    Promise<undefined> delete(CookieStoreDeleteOptions options);
 };
 
 // https://cookiestore.spec.whatwg.org/#Window