mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-02 09:18:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Fix crash when skipping to previous word with ctrl+left arrow

Browse source 
Before this change, skipping a word to the left in a non empty text
input element would crash when near the end of the text as the
offset + length of the substring would exceed the length of the string.
This commit is contained in:
Nathan van der Kamp 2024-11-24 23:40:07 +01:00 • committed by Tim Flynn
parent 4913dac745
commit 1870f1a0a8
Notes: github-actions[bot] 2024-11-25 02:03:28 +00:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/FormAssociatedElement.cpp
View file

@ -794,7 +794,7 @@ void FormAssociatedTextControlElement::decrement_cursor_position_to_previous_wor
while (true) {
if (auto offset = text_node->word_segmenter().previous_boundary(m_selection_end); offset.has_value()) {
auto word = text_node->data().code_points().substring_view(m_selection_end, m_selection_end - *offset);
auto word = text_node->data().code_points().substring_view(*offset, m_selection_end - *offset);
if (collapse == CollapseSelection::Yes) {
collapse_selection_to_offset(*offset);
} else {