mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-22 10:19:20 +00:00
AK: Rename the const
overload of FixedMemoryStream::bytes()
Due to overload resolutions rules, this simple code provokes a crash: ReadonlyBytes readonly_bytes{}; FixedMemoryStream stream{readonly_bytes}; ReadonlyBytes give_them_back{stream.bytes()}; // -> Panics on VERIFY(m_writing_enabled); // but this is fine: auto bytes = static_cast<FixedMemoryStream const&>(*stream).bytes() If we need to be explicit about it, let's rename the overload instead of adding that `static_cast`.
This commit is contained in:
parent
66c9696687
commit
18b7ddd0b5
Notes:
sideshowbarker
2024-07-17 05:09:48 +09:00
Author: https://github.com/LucasChollet
Commit: 18b7ddd0b5
Pull-request: https://github.com/SerenityOS/serenity/pull/20135
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/supercomputer7
3 changed files with 3 additions and 3 deletions
|
@ -32,7 +32,7 @@ public:
|
|||
virtual ErrorOr<void> write_until_depleted(ReadonlyBytes bytes) override;
|
||||
|
||||
Bytes bytes();
|
||||
ReadonlyBytes bytes() const;
|
||||
ReadonlyBytes readonly_bytes() const;
|
||||
size_t offset() const;
|
||||
size_t remaining() const;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue