AK: Reject BitStream reads beyond EOF by default

The only exception to this is the lossless WebP decoder, which legitimately relies on this behavior, even upstream.
Author: https://github.com/timschumi Commit: 197331c922 Pull-request: https://github.com/SerenityOS/serenity/pull/21890 Issue: https://github.com/SerenityOS/serenity/issues/21869 Reviewed-by: https://github.com/IdanHo Reviewed-by: https://github.com/LucasChollet Reviewed-by: https://github.com/trflynn89
2025-09-03 08:08:43 +00:00 · 2023-11-11 13:57:48 +01:00 · 2023-11-11 13:57:48 +01:00 · 197331c922 · 2024-07-17 11:29:41 +09:00
commit 197331c922
parent cb03d3d78f
2 changed files with 3 additions and 3 deletions
--- a/AK/BitStream.h
+++ b/AK/BitStream.h
@ -156,7 +156,7 @@ public:
        FillWithZero,
    };

-    explicit LittleEndianInputBitStream(MaybeOwned<Stream> stream, UnsatisfiableReadBehavior unsatisfiable_read_behavior = UnsatisfiableReadBehavior::FillWithZero)
+    explicit LittleEndianInputBitStream(MaybeOwned<Stream> stream, UnsatisfiableReadBehavior unsatisfiable_read_behavior = UnsatisfiableReadBehavior::Reject)
        : LittleEndianBitStream(move(stream))
        , m_unsatisfiable_read_behavior(unsatisfiable_read_behavior)
    {