mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Align to padding edge only auto positioned abspos grid items

Browse source 
Containing block for abspos grid items depends on their grid placement:
- if element has definite grid position, then corresponding grid area
  should be used as a containing block
- if element does not have definite grid position, then padding edge of
  grid container should be used as a containing block

So offset should be adjusted for paddings only for boxes without
definite grid position.
This commit is contained in:
Aliaksandr Kalenik 2024-09-21 19:31:27 +02:00 • committed by Andreas Kling
commit 19afc5b11b
Notes: github-actions[bot] 2024-09-21 18:11:49 +00:00
3 changed files with 61 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibWeb/Layout/GridFormattingContext.cpp
View file

@ -1899,10 +1899,11 @@ void GridFormattingContext::run(AvailableSpace const& available_space)
void GridFormattingContext::layout_absolutely_positioned_element(Box const& box)
{
auto& containing_block_state = m_state.get_mutable(*box.containing_block());
auto& box_state = m_state.get_mutable(box);
auto const& computed_values = box.computed_values();
auto is_auto_positioned = is_auto_positioned_track(computed_values.grid_row_start(), computed_values.grid_row_end()) || is_auto_positioned_track(computed_values.grid_column_start(), computed_values.grid_column_end());
auto row_placement_position = resolve_grid_position(box, GridDimension::Row);
auto column_placement_position = resolve_grid_position(box, GridDimension::Column);
@ -2000,8 +2001,12 @@ void GridFormattingContext::layout_absolutely_positioned_element(Box const& box)
used_offset.set_x(grid_area_rect.x() + box_state.inset_left + box_state.margin_box_left());
used_offset.set_y(grid_area_rect.y() + box_state.inset_top + box_state.margin_box_top());
// NOTE: Absolutely positioned boxes are relative to the *padding edge* of the containing block.
used_offset.translate_by(-containing_block_state.padding_left, -containing_block_state.padding_top);
// NOTE: Absolutely positioned boxes with auto-placement are relative to the *padding edge* of the containing block.
if (is_auto_positioned) {
auto const& containing_block_state = m_state.get_mutable(*box.containing_block());
used_offset.translate_by(-containing_block_state.padding_left, -containing_block_state.padding_top);
}
box_state.set_content_offset(used_offset);
if (independent_formatting_context)