LibJS: Avoid roundtrip through Value for comparison bytecode evaluation
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run

1.1x speedup on strictly-equals-object.js
This commit is contained in:
Shannon Booth 2025-05-08 15:19:35 +12:00 committed by Andreas Kling
commit 19bf897116
Notes: github-actions[bot] 2025-05-08 18:40:23 +00:00
4 changed files with 42 additions and 42 deletions

View file

@ -461,10 +461,10 @@ private:
friend constexpr Value js_undefined();
friend constexpr Value js_null();
friend constexpr Value js_special_empty_value();
friend ThrowCompletionOr<Value> greater_than(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<Value> greater_than_equals(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<Value> less_than(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<Value> less_than_equals(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<bool> greater_than(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<bool> greater_than_equals(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<bool> less_than(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<bool> less_than_equals(VM&, Value lhs, Value rhs);
friend ThrowCompletionOr<Value> add(VM&, Value lhs, Value rhs);
friend bool same_value_non_number(Value lhs, Value rhs);
};
@ -499,10 +499,10 @@ inline Value js_negative_infinity()
return Value(-INFINITY);
}
ThrowCompletionOr<Value> greater_than(VM&, Value lhs, Value rhs);
ThrowCompletionOr<Value> greater_than_equals(VM&, Value lhs, Value rhs);
ThrowCompletionOr<Value> less_than(VM&, Value lhs, Value rhs);
ThrowCompletionOr<Value> less_than_equals(VM&, Value lhs, Value rhs);
ThrowCompletionOr<bool> greater_than(VM&, Value lhs, Value rhs);
ThrowCompletionOr<bool> greater_than_equals(VM&, Value lhs, Value rhs);
ThrowCompletionOr<bool> less_than(VM&, Value lhs, Value rhs);
ThrowCompletionOr<bool> less_than_equals(VM&, Value lhs, Value rhs);
ThrowCompletionOr<Value> bitwise_and(VM&, Value lhs, Value rhs);
ThrowCompletionOr<Value> bitwise_or(VM&, Value lhs, Value rhs);
ThrowCompletionOr<Value> bitwise_xor(VM&, Value lhs, Value rhs);