LibGfx: Stop using a Utf8View that points to a temporary String

Author: https://github.com/IdanHo
Commit: 1a19d2c2df
Pull-request: https://github.com/SerenityOS/serenity/pull/9805
Reviewed-by: https://github.com/sin-ack ✅

Userland/Libraries/LibGfx/Painter.cpp

@@ -1492,7 +1492,7 @@ void Painter::do_draw_text(IntRect const& rect, Utf8View const& text, Font const
                 // compatible with draw_text_line.
                 StringBuilder builder;
                 builder.append(directional_run.text());
-                auto line_text = Utf8View { builder.to_string() };
+                auto line_text = Utf8View { builder.string_view() };
 
                 draw_text_line(run_rect, line_text, font, alignment, directional_run.direction(), draw_glyph);
                 if (line_direction == TextDirection::LTR)