AK: Move String::~String() and String::destroy_string() to StringBase

Author: https://github.com/DanShaders
Commit: 1b09a1851e
Pull-request: https://github.com/SerenityOS/serenity/pull/21661
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/kleinesfilmroellchen
Reviewed-by: https://github.com/trflynn89

AK/String.cpp

@@ -122,12 +122,6 @@ void StringData::compute_hash() const
 
 }
 
-void String::destroy_string()
-{
-    if (!is_short_string())
-        m_data->unref();
-}
-
 String String::from_utf8_without_validation(ReadonlyBytes bytes)
 {
     if (bytes.size() <= MAX_SHORT_STRING_BYTE_COUNT) {