AK: Move String::~String() and String::destroy_string() to StringBase

Author: https://github.com/DanShaders
Commit: 1b09a1851e
Pull-request: https://github.com/SerenityOS/serenity/pull/21661
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/kleinesfilmroellchen
Reviewed-by: https://github.com/trflynn89

AK/String.h

@@ -48,12 +48,6 @@ public:
 
     using StringBase::StringBase;
 
-    constexpr ~String()
-    {
-        if (!is_constant_evaluated())
-            destroy_string();
-    }
-
     // Creates an empty (zero-length) String.
     constexpr String()
         : StringBase(ShortString { SHORT_STRING_FLAG, {} })
@@ -209,8 +203,6 @@ public:
 
 private:
     using ShortString = Detail::ShortString;
-
-    void destroy_string();
 };
 
 template<>