mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-15 23:09:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

WebContent: Add timeouts to WebDriver window state modification methods

Browse source
This commit is contained in:
Tim Ledbetter 2024-08-09 21:09:59 +01:00 • committed by Andreas Kling
commit 1b2f35c3af
Notes: github-actions[bot] 2024-08-10 08:38:33 +00:00
1 changed files with 16 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

22
Userland/Services/WebContent/WebDriverConnection.cpp
View file

@ -1975,10 +1975,15 @@ void WebDriverConnection::restore_the_window()
m_page_client->page_did_request_restore_window(); m_page_client->page_did_request_restore_window();
// Do not return from this operation until the visibility state of the top-level browsing context’s active document has reached the visible state, or until the operation times out. // Do not return from this operation until the visibility state of the top-level browsing context’s active document has reached the visible state, or until the operation times out.
// FIXME: Implement timeouts. // FIXME: It isn't clear which timeout should be used here.
Web::Platform::EventLoopPlugin::the().spin_until([this]() { auto page_load_timeout_fired = false;
auto timer = Core::Timer::create_single_shot(m_timeouts_configuration.page_load_timeout, [&] {
page_load_timeout_fired = true;
});
Web::Platform::EventLoopPlugin::the().spin_until([&]() {
auto state = m_page_client->page().top_level_traversable()->system_visibility_state(); auto state = m_page_client->page().top_level_traversable()->system_visibility_state();
return state == Web::HTML::VisibilityState::Visible; return page_load_timeout_fired || state == Web::HTML::VisibilityState::Visible;
}); });
} }
@ -1999,10 +2004,15 @@ Gfx::IntRect WebDriverConnection::iconify_the_window()
auto rect = m_page_client->page_did_request_minimize_window(); auto rect = m_page_client->page_did_request_minimize_window();
// Do not return from this operation until the visibility state of the top-level browsing context’s active document has reached the hidden state, or until the operation times out. // Do not return from this operation until the visibility state of the top-level browsing context’s active document has reached the hidden state, or until the operation times out.
// FIXME: Implement timeouts. // FIXME: It isn't clear which timeout should be used here.
Web::Platform::EventLoopPlugin::the().spin_until([this]() { auto page_load_timeout_fired = false;
auto timer = Core::Timer::create_single_shot(m_timeouts_configuration.page_load_timeout, [&] {
page_load_timeout_fired = true;
});
Web::Platform::EventLoopPlugin::the().spin_until([&]() {
auto state = m_page_client->page().top_level_traversable()->system_visibility_state(); auto state = m_page_client->page().top_level_traversable()->system_visibility_state();
return state == Web::HTML::VisibilityState::Hidden; return page_load_timeout_fired || state == Web::HTML::VisibilityState::Hidden;
}); });
return rect; return rect;