mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 20:59:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Resolve percentage values against 1 in CSSColor

Browse source 
This was a silly mistake on my end and percentages values are not
covered by device-independent color space, so I had to add support for
srgb to run a WPT test that made me realize the mistake.

This makes the following test pass:
 - css/css-color/predefined-002.html
This commit is contained in:
Lucas CHOLLET 2024-11-13 21:33:03 -05:00 • committed by Sam Atkins
commit 1b38ebcc7f
Notes: github-actions[bot] 2024-11-14 09:27:24 +00:00
2 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/CSS/StyleValues/CSSColor.cpp
View file

@ -58,9 +58,9 @@ String CSSColor::to_string() const
Color CSSColor::to_color(Optional<Layout::NodeWithStyle const&>) const
{
auto const c1 = resolve_with_reference_value(m_properties.channels[0], 100).value_or(0);
auto const c2 = resolve_with_reference_value(m_properties.channels[1], 100).value_or(0);
auto const c3 = resolve_with_reference_value(m_properties.channels[2], 100).value_or(0);
auto const c1 = resolve_with_reference_value(m_properties.channels[0], 1).value_or(0);
auto const c2 = resolve_with_reference_value(m_properties.channels[1], 1).value_or(0);
auto const c3 = resolve_with_reference_value(m_properties.channels[2], 1).value_or(0);
auto const alpha_val = resolve_alpha(m_properties.alpha).value_or(1);
if (color_type() == ColorType::sRGB) {