mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Allow border="0" on HTMLObjectElement

Browse source
This commit is contained in:
Andreas Kling 2024-11-23 11:47:45 +01:00 • committed by Andreas Kling
commit 1b4763f75f
Notes: github-actions[bot] 2024-11-23 13:43:32 +00:00
2 changed files with 14 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -88,7 +88,7 @@ void HTMLObjectElement::apply_presentational_hints(CSS::StyleProperties& style)
else if (value.equals_ignoring_ascii_case("middle"sv)) else if (value.equals_ignoring_ascii_case("middle"sv))
style.set_property(CSS::PropertyID::TextAlign, CSS::CSSKeywordValue::create(CSS::Keyword::Middle)); style.set_property(CSS::PropertyID::TextAlign, CSS::CSSKeywordValue::create(CSS::Keyword::Middle));
} else if (name == HTML::AttributeNames::border) { } else if (name == HTML::AttributeNames::border) {
if (auto parsed_value = parse_non_negative_integer(value); parsed_value.has_value() && *parsed_value > 0) { if (auto parsed_value = parse_non_negative_integer(value); parsed_value.has_value()) {
auto width_style_value = CSS::LengthStyleValue::create(CSS::Length::make_px(*parsed_value)); auto width_style_value = CSS::LengthStyleValue::create(CSS::Length::make_px(*parsed_value));
style.set_property(CSS::PropertyID::BorderTopWidth, width_style_value); style.set_property(CSS::PropertyID::BorderTopWidth, width_style_value);
style.set_property(CSS::PropertyID::BorderRightWidth, width_style_value); style.set_property(CSS::PropertyID::BorderRightWidth, width_style_value);

27
Tests/LibWeb/Text/expected/wpt-import/html/rendering/pixel-length-attributes.txt
View file

@ -6,8 +6,7 @@ Rerun
Found 588 tests Found 588 tests
576 Pass 588 Pass
12 Fail
Details Details
Result Test Name MessagePass <iframe marginwidth="200"> mapping to marginLeft Result Test Name MessagePass <iframe marginwidth="200"> mapping to marginLeft
Pass <iframe marginwidth="1007"> mapping to marginLeft Pass <iframe marginwidth="1007"> mapping to marginLeft
@ -435,9 +434,9 @@ Pass <object border=" 00523 "> mapping to borderTopWidth
Pass <object border="200."> mapping to borderTopWidth Pass <object border="200."> mapping to borderTopWidth
Pass <object border="200.25"> mapping to borderTopWidth Pass <object border="200.25"> mapping to borderTopWidth
Pass <object border="200.7"> mapping to borderTopWidth Pass <object border="200.7"> mapping to borderTopWidth
Fail <object border="0"> mapping to borderTopWidth Pass <object border="0"> mapping to borderTopWidth
Fail <object border="-0"> mapping to borderTopWidth Pass <object border="-0"> mapping to borderTopWidth
Fail <object border="+0"> mapping to borderTopWidth Pass <object border="+0"> mapping to borderTopWidth
Pass <object border="+200"> mapping to borderTopWidth Pass <object border="+200"> mapping to borderTopWidth
Pass <object border="200in"> mapping to borderTopWidth Pass <object border="200in"> mapping to borderTopWidth
Pass <object border="200.25in"> mapping to borderTopWidth Pass <object border="200.25in"> mapping to borderTopWidth
@ -456,9 +455,9 @@ Pass <object border=" 00523 "> mapping to borderRightWidth
Pass <object border="200."> mapping to borderRightWidth Pass <object border="200."> mapping to borderRightWidth
Pass <object border="200.25"> mapping to borderRightWidth Pass <object border="200.25"> mapping to borderRightWidth
Pass <object border="200.7"> mapping to borderRightWidth Pass <object border="200.7"> mapping to borderRightWidth
Fail <object border="0"> mapping to borderRightWidth Pass <object border="0"> mapping to borderRightWidth
Fail <object border="-0"> mapping to borderRightWidth Pass <object border="-0"> mapping to borderRightWidth
Fail <object border="+0"> mapping to borderRightWidth Pass <object border="+0"> mapping to borderRightWidth
Pass <object border="+200"> mapping to borderRightWidth Pass <object border="+200"> mapping to borderRightWidth
Pass <object border="200in"> mapping to borderRightWidth Pass <object border="200in"> mapping to borderRightWidth
Pass <object border="200.25in"> mapping to borderRightWidth Pass <object border="200.25in"> mapping to borderRightWidth
@ -477,9 +476,9 @@ Pass <object border=" 00523 "> mapping to borderBottomWidth
Pass <object border="200."> mapping to borderBottomWidth Pass <object border="200."> mapping to borderBottomWidth
Pass <object border="200.25"> mapping to borderBottomWidth Pass <object border="200.25"> mapping to borderBottomWidth
Pass <object border="200.7"> mapping to borderBottomWidth Pass <object border="200.7"> mapping to borderBottomWidth
Fail <object border="0"> mapping to borderBottomWidth Pass <object border="0"> mapping to borderBottomWidth
Fail <object border="-0"> mapping to borderBottomWidth Pass <object border="-0"> mapping to borderBottomWidth
Fail <object border="+0"> mapping to borderBottomWidth Pass <object border="+0"> mapping to borderBottomWidth
Pass <object border="+200"> mapping to borderBottomWidth Pass <object border="+200"> mapping to borderBottomWidth
Pass <object border="200in"> mapping to borderBottomWidth Pass <object border="200in"> mapping to borderBottomWidth
Pass <object border="200.25in"> mapping to borderBottomWidth Pass <object border="200.25in"> mapping to borderBottomWidth
@ -498,9 +497,9 @@ Pass <object border=" 00523 "> mapping to borderLeftWidth
Pass <object border="200."> mapping to borderLeftWidth Pass <object border="200."> mapping to borderLeftWidth
Pass <object border="200.25"> mapping to borderLeftWidth Pass <object border="200.25"> mapping to borderLeftWidth
Pass <object border="200.7"> mapping to borderLeftWidth Pass <object border="200.7"> mapping to borderLeftWidth
Fail <object border="0"> mapping to borderLeftWidth Pass <object border="0"> mapping to borderLeftWidth
Fail <object border="-0"> mapping to borderLeftWidth Pass <object border="-0"> mapping to borderLeftWidth
Fail <object border="+0"> mapping to borderLeftWidth Pass <object border="+0"> mapping to borderLeftWidth
Pass <object border="+200"> mapping to borderLeftWidth Pass <object border="+200"> mapping to borderLeftWidth
Pass <object border="200in"> mapping to borderLeftWidth Pass <object border="200in"> mapping to borderLeftWidth
Pass <object border="200.25in"> mapping to borderLeftWidth Pass <object border="200.25in"> mapping to borderLeftWidth