mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 17:49:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use a stable sort for searching URLSearchParams

Browse source 
Quick sort is not a stable sort. This meant we had a subtle issue
implementing this portion of the spec comment:

 > The relative order between name-value pairs with equal names must
 > be preserved.

Switch to insertion sort which is a stable sort, and properly handles
keys which are the same.

Fixes 8 tests on  https://wpt.live/url/urlsearchparams-sort.any.html
This commit is contained in:
Shannon Booth 2024-08-11 11:27:18 +12:00 • committed by Tim Ledbetter
commit 1ba6dbd86c
Notes: github-actions[bot] 2024-08-12 22:02:31 +00:00
3 changed files with 17 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Tests/LibWeb/Text/input/URL/url-search-params-sort-order-stable.html Normal file
View file

@ -0,0 +1,11 @@
<script src="../include.js"></script>
<script>
test(() => {
let params = new URLSearchParams("z=z&=f&=t&=x");
params.sort();
println(params.toString())
for (const [key, value] of params) {
println(`'${key}' => '${value}'`);
}
})
</script>