mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-06 17:11:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Keep delaying the load event on concurrent <object> tasks

Browse source 
If we queue the <object> representation task multiple times in a row, we
would end up clearing the delayer after the first task completed. We
must continue delaying the load event until the last task completes.

This becomes an issue in an upcoming commit to import the acid2 test.
This commit is contained in:
Timothy Flynn 2025-05-22 12:16:11 -04:00 • committed by Tim Flynn
parent 874e094ed8
commit 1bc7a52587
Notes: github-actions[bot] 2025-05-22 21:45:53 +00:00
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/HTML/HTMLObjectElement.cpp
View file

@ -238,10 +238,10 @@ void HTMLObjectElement::queue_element_task_to_run_object_representation_steps()
return;
// This task being queued or actively running must delay the load event of the element's node document.
m_document_load_event_delayer_for_object_representation_task.emplace(document());
m_document_load_event_delayer_for_object_representation_task.empend(document());
queue_an_element_task(HTML::Task::Source::DOMManipulation, [this]() {
ScopeGuard guard { [&]() { m_document_load_event_delayer_for_object_representation_task.clear(); } };
ScopeGuard guard { [&]() { m_document_load_event_delayer_for_object_representation_task.take_last(); } };
auto& realm = this->realm();
auto& vm = realm.vm();
@ -327,7 +327,7 @@ void HTMLObjectElement::queue_element_task_to_run_object_representation_steps()
// Fetching the resource must delay the load event of the element's node document until the task that is
// queued by the networking task source once the resource has been fetched (defined next) has been run.
m_document_load_event_delayer_for_resource_load.emplace(document());
m_document_load_event_delayer_for_resource_load.empend(document());
// 6. If the resource is not yet available (e.g. because the resource was not available in the cache, so that
// loading the resource required making a request over the network), then jump to the step below labeled
@ -345,7 +345,7 @@ void HTMLObjectElement::queue_element_task_to_run_object_representation_steps()
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-object-element:concept-event-fire-2
void HTMLObjectElement::resource_did_fail()
{
ScopeGuard guard { [&]() { m_document_load_event_delayer_for_resource_load.clear(); } };
ScopeGuard guard { [&]() { m_document_load_event_delayer_for_resource_load.take_last(); } };
// 3.7. If the load failed (e.g. there was an HTTP 404 error, there was a DNS error), fire an event named error at
// the element, then jump to the step below labeled fallback.
@ -356,7 +356,7 @@ void HTMLObjectElement::resource_did_fail()
// https://html.spec.whatwg.org/multipage/iframe-embed-object.html#object-type-detection
void HTMLObjectElement::resource_did_load(Fetch::Infrastructure::Response const& response, ReadonlyBytes data)
{
ScopeGuard guard { [&]() { m_document_load_event_delayer_for_resource_load.clear(); } };
ScopeGuard guard { [&]() { m_document_load_event_delayer_for_resource_load.take_last(); } };
// 3.8. Determine the resource type, as follows: