mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Update get_an_elements_noopener() to current spec

Browse source 
Note that this preemptively includes this fix to step 3:
https://github.com/whatwg/html/pull/10962
This commit is contained in:
Sam Atkins 2025-01-29 16:56:55 +00:00 • committed by Tim Ledbetter
commit 1bd73184da
Notes: github-actions[bot] 2025-01-31 17:28:04 +00:00
7 changed files with 25 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Libraries/LibWeb/HTML/HTMLElement.cpp
View file

@ -930,9 +930,10 @@ String HTMLElement::get_an_elements_target(Optional<String> target) const
}
// https://html.spec.whatwg.org/multipage/links.html#get-an-element's-noopener
TokenizedFeature::NoOpener HTMLElement::get_an_elements_noopener(StringView target) const
TokenizedFeature::NoOpener HTMLElement::get_an_elements_noopener(URL::URL const& url, StringView target) const
{
// To get an element's noopener, given an a, area, or form element element and a string target:
// To get an element's noopener, given an a, area, or form element element, a URL record url, and a string target,
// perform the following steps. They return a boolean.
auto rel = MUST(get_attribute_value(HTML::AttributeNames::rel).to_lowercase());
auto link_types = rel.bytes_as_string_view().split_view_if(Infra::is_ascii_whitespace);
@ -945,7 +946,20 @@ TokenizedFeature::NoOpener HTMLElement::get_an_elements_noopener(StringView targ
if (!link_types.contains_slow("opener"sv) && Infra::is_ascii_case_insensitive_match(target, "_blank"sv))
return TokenizedFeature::NoOpener::Yes;
// 3. Return false.
// 3. If url's blob URL entry is not null:
if (url.blob_url_entry().has_value()) {
// 1. Let blobOrigin be url's blob URL entry's environment's origin.
auto const& blob_origin = url.blob_url_entry()->environment.origin;
// 2. Let topLevelOrigin be element's relevant settings object's top-level origin.
auto const& top_level_origin = relevant_settings_object(*this).top_level_origin;
// 3. If blobOrigin is not same site with topLevelOrigin, then return true.
if (!blob_origin.is_same_site(top_level_origin))
return TokenizedFeature::NoOpener::Yes;
}
// 4. Return false.
return TokenizedFeature::NoOpener::No;
}