mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-20 09:11:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

LibWeb: Reduce SelectItemOption struct from 40 to 32 bytes

Browse source
This commit is contained in:
Pavel Shliak 2024-11-11 14:22:44 +04:00 • committed by Andreas Kling
parent 566870b2bd
commit 1bdc41faa1
Notes: github-actions[bot] 2024-11-11 16:07:12 +00:00
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -389,7 +389,7 @@ void HTMLSelectElement::show_the_picker_if_applicable()
for (auto const& child : opt_group_element.children_as_vector()) { for (auto const& child : opt_group_element.children_as_vector()) {
if (is<HTMLOptionElement>(*child)) { if (is<HTMLOptionElement>(*child)) {
auto& option_element = verify_cast<HTMLOptionElement>(*child); auto& option_element = verify_cast<HTMLOptionElement>(*child);
option_group_items.append(SelectItemOption { id_counter++, strip_newlines(option_element.text_content()), option_element.value(), option_element.selected(), option_element.disabled(), option_element }); option_group_items.append(SelectItemOption { id_counter++, option_element.selected(), option_element.disabled(), option_element, strip_newlines(option_element.text_content()), option_element.value() });
} }
} }
m_select_items.append(SelectItemOptionGroup { opt_group_element.get_attribute(AttributeNames::label).value_or(String {}), option_group_items }); m_select_items.append(SelectItemOptionGroup { opt_group_element.get_attribute(AttributeNames::label).value_or(String {}), option_group_items });
@ -397,7 +397,7 @@ void HTMLSelectElement::show_the_picker_if_applicable()
if (is<HTMLOptionElement>(*child)) { if (is<HTMLOptionElement>(*child)) {
auto& option_element = verify_cast<HTMLOptionElement>(*child); auto& option_element = verify_cast<HTMLOptionElement>(*child);
m_select_items.append(SelectItemOption { id_counter++, strip_newlines(option_element.text_content()), option_element.value(), option_element.selected(), option_element.disabled(), option_element }); m_select_items.append(SelectItemOption { id_counter++, option_element.selected(), option_element.disabled(), option_element, strip_newlines(option_element.text_content()), option_element.value() });
} }
if (is<HTMLHRElement>(*child)) if (is<HTMLHRElement>(*child))

2
Libraries/LibWeb/HTML/SelectItem.cpp
View file

@ -27,7 +27,7 @@ ErrorOr<Web::HTML::SelectItemOption> IPC::decode(Decoder& decoder)
auto value = TRY(decoder.decode<String>()); auto value = TRY(decoder.decode<String>());
auto selected = TRY(decoder.decode<bool>()); auto selected = TRY(decoder.decode<bool>());
auto disabled = TRY(decoder.decode<bool>()); auto disabled = TRY(decoder.decode<bool>());
return Web::HTML::SelectItemOption { id, move(label), move(value), selected, disabled }; return Web::HTML::SelectItemOption { id, selected, disabled, {}, move(label), move(value) };
} }
template<> template<>

4
Libraries/LibWeb/HTML/SelectItem.h
View file

@ -14,11 +14,11 @@ namespace Web::HTML {
struct SelectItemOption { struct SelectItemOption {
u32 id { 0 }; u32 id { 0 };
String label {};
String value {};
bool selected { false }; bool selected { false };
bool disabled { false }; bool disabled { false };
JS::GCPtr<HTMLOptionElement> option_element {}; JS::GCPtr<HTMLOptionElement> option_element {};
String label {};
String value {};
}; };
struct SelectItemOptionGroup { struct SelectItemOptionGroup {