mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-17 07:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use GC::Ptr for BrowsingContext pointer saved in Document

Browse source 
Likely we forgot to update `WeakPtr` to `GC::Ptr` after converting
`BrowsingContext` to GC-allocated object.
This commit is contained in:
Aliaksandr Kalenik 2025-07-17 16:26:59 +02:00 • committed by Sam Atkins
commit 1bf4d3391e
Notes: github-actions[bot] 2025-07-17 14:56:57 +00:00
5 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/DOM/Document.cpp
View file

@ -544,6 +544,7 @@ void Document::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_inspected_node);
visitor.visit(m_highlighted_node);
visitor.visit(m_active_favicon);
visitor.visit(m_browsing_context);
visitor.visit(m_focused_element);
visitor.visit(m_active_element);
visitor.visit(m_target_element);
@ -4239,7 +4240,7 @@ GC::Ptr<HTML::HTMLParser> Document::active_parser()
return m_parser;
}
void Document::set_browsing_context(HTML::BrowsingContext* browsing_context)
void Document::set_browsing_context(GC::Ptr<HTML::BrowsingContext> browsing_context)
{
m_browsing_context = browsing_context;
}

8
Libraries/LibWeb/DOM/Document.h
View file

@ -308,10 +308,10 @@ public:
String title() const;
WebIDL::ExceptionOr<void> set_title(String const&);
HTML::BrowsingContext* browsing_context() { return m_browsing_context.ptr(); }
HTML::BrowsingContext const* browsing_context() const { return m_browsing_context.ptr(); }
GC::Ptr<HTML::BrowsingContext> browsing_context() { return m_browsing_context; }
GC::Ptr<HTML::BrowsingContext const> browsing_context() const { return m_browsing_context; }
void set_browsing_context(HTML::BrowsingContext*);
void set_browsing_context(GC::Ptr<HTML::BrowsingContext>);
Page& page();
Page const& page() const;
@ -960,7 +960,7 @@ private:
OwnPtr<CSS::StyleComputer> m_style_computer;
GC::Ptr<CSS::StyleSheetList> m_style_sheets;
GC::Ptr<Node> m_active_favicon;
WeakPtr<HTML::BrowsingContext> m_browsing_context;
GC::Ptr<HTML::BrowsingContext> m_browsing_context;
URL::URL m_url;
mutable OwnPtr<ElementByIdMap> m_element_by_id;