mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-18 08:20:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Return computed grid-template-rows/columns if there's no used

Browse source 
If grid-template-rows or grid-template-columns queried for a box that is
not a grid container, the result should be computed value instead of
null.

Fixes crashing in inspector.
This commit is contained in:
Aliaksandr Kalenik 2024-09-09 18:13:24 +02:00 • committed by Andreas Kling
commit 1d7c9cd1e1
Notes: github-actions[bot] 2024-09-09 19:11:16 +00:00
3 changed files with 30 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Tests/LibWeb/Text/input/getComputedStyle-grid-template-rows-columns.html
View file

@ -10,12 +10,25 @@
height: 50px;
background-color: lightblue;
}
.not-a-grid {
grid-template-columns: auto auto;
}
</style>
<div class="grid-container" style="grid-template-columns: auto auto"><div class="grid-item"></div><div class="grid-item"></div><div class="grid-item"></div><div class="grid-item"></div></div>
<div class="grid-container" style="grid-template-columns: auto auto">
<div class="grid-item"></div>
<div class="grid-item"></div>
<div class="grid-item"></div>
<div class="grid-item"></div>
</div>
<div class="not-a-grid"></div>
<script>
test(() => {
const grid = document.querySelector(".grid-container");
println(getComputedStyle(grid).gridTemplateColumns);
println(getComputedStyle(grid).gridTemplateRows);
const not_a_grid = document.querySelector(".not-a-grid");
println(getComputedStyle(not_a_grid).gridTemplateColumns);
});
</script>