mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-21 20:15:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/HTML: Remove microtask invocation of update selectedness

Browse source 
This is fundametally broken. A microtask only finishes after all
javascript has finished running. The selectedness of a select element
is observable by javascript, so any changes which are made as a result
of children changing associated with a select element should be made
through the children update steps and friends.
This commit is contained in:
Shannon Booth 2025-01-26 18:35:24 +13:00 • committed by Andrew Kaster
parent b35979c3f7
commit 1db568d06f
Notes: github-actions[bot] 2025-01-30 20:57:29 +00:00
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -505,11 +505,6 @@ void HTMLSelectElement::did_select_item(Optional<u32> const& id)
void HTMLSelectElement::form_associated_element_was_inserted()
{
create_shadow_tree_if_needed();
// Wait until children are ready
queue_an_element_task(HTML::Task::Source::Microtask, [this] {
update_selectedness();
});
}
void HTMLSelectElement::form_associated_element_was_removed(DOM::Node*)