From 1e6f703b308cb3e628ccce2f6c09cbad58a76764 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Fri, 14 Mar 2025 10:46:09 +0000 Subject: [PATCH] LibWeb/CSS: Compare MediaFeatureValues using references not copies --- Libraries/LibWeb/CSS/MediaQuery.cpp | 2 +- Libraries/LibWeb/CSS/MediaQuery.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/LibWeb/CSS/MediaQuery.cpp b/Libraries/LibWeb/CSS/MediaQuery.cpp index 87cd73a854a..5e3cbb31eb2 100644 --- a/Libraries/LibWeb/CSS/MediaQuery.cpp +++ b/Libraries/LibWeb/CSS/MediaQuery.cpp @@ -144,7 +144,7 @@ MatchResult MediaFeature::evaluate(HTML::Window const* window) const VERIFY_NOT_REACHED(); } -bool MediaFeature::compare(HTML::Window const& window, MediaFeatureValue left, Comparison comparison, MediaFeatureValue right) +bool MediaFeature::compare(HTML::Window const& window, MediaFeatureValue const& left, Comparison comparison, MediaFeatureValue const& right) { if (!left.is_same_type(right)) return false; diff --git a/Libraries/LibWeb/CSS/MediaQuery.h b/Libraries/LibWeb/CSS/MediaQuery.h index 2035c9a5073..3c5edded845 100644 --- a/Libraries/LibWeb/CSS/MediaQuery.h +++ b/Libraries/LibWeb/CSS/MediaQuery.h @@ -173,7 +173,7 @@ private: { } - static bool compare(HTML::Window const& window, MediaFeatureValue left, Comparison comparison, MediaFeatureValue right); + static bool compare(HTML::Window const& window, MediaFeatureValue const& left, Comparison comparison, MediaFeatureValue const& right); MediaFeatureValue const& value() const { return m_value.get(); } Range const& range() const { return m_value.get(); }