mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-13 11:39:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't crash on getClientRects() in document without navigable

Browse source 
I previously believed there was no way a detached document should have
layout information, but it turns out there is a way: getComputedStyle().

So we need to account for cases where we have a layout node, but no
navigable, since that is a state we can get into at this moment.

Fixes #354
This commit is contained in:
Andreas Kling 2024-08-05 11:28:42 +02:00 • committed by Andreas Kling
commit 1e7b17f150
Notes: github-actions[bot] 2024-08-05 12:56:54 +00:00
3 changed files with 24 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Tests/LibWeb/Text/input/CSSOMView/getClientRects-in-detached-document.html Normal file
View file

@ -0,0 +1,16 @@
<script src="../include.js"></script>
<script>
test(() => {
let doc = document.implementation.createHTMLDocument();
let div = doc.createElement("div");
doc.body.appendChild(div);
// NOTE: We do a getComputedStyle() to trick the document into doing some style/layout work.
// In the future, we may optimize away some of this work, which would potentially
// make the test not work as intended anymore.
println(getComputedStyle(div));
println(div.getClientRects());
println("PASS (didn't crash)");
});
</script>