mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 01:00:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Clone all attribute properties when cloning a single node

Browse source 
Previously, the namespace of the attributes on the cloned element was
not being set.
This commit is contained in:
Tim Ledbetter 2025-01-11 17:56:05 +00:00 • committed by Jelle Raaijmakers
commit 1e9e2b6564
Notes: github-actions[bot] 2025-01-11 22:11:11 +00:00
3 changed files with 88 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibWeb/DOM/Node.cpp
View file

@ -1099,11 +1099,24 @@ WebIDL::ExceptionOr<GC::Ref<Node>> Node::clone_single_node(Document& document) c
auto element_copy = TRY(DOM::create_element(document, element.local_name(), element.namespace_uri(), element.prefix(), element.is_value())); auto element_copy = TRY(DOM::create_element(document, element.local_name(), element.namespace_uri(), element.prefix(), element.is_value()));
// 2. For each attribute of node’s attribute list: // 2. For each attribute of node’s attribute list:
element.for_each_attribute([&](auto& name, auto& value) { Optional<WebIDL::Exception> maybe_exception;
// FIXME: 1. Let copyAttribute be the result of cloning a single node given attribute and document. element.for_each_attribute([&](Attr const& attr) {
// 1. Let copyAttribute be the result of cloning a single node given attribute and document.
auto copy_attribute_or_error = attr.clone_single_node(document);
if (copy_attribute_or_error.is_error()) {
maybe_exception = copy_attribute_or_error.release_error();
return;
}
auto copy_attribute = copy_attribute_or_error.release_value();
// 2. Append copyAttribute to copy. // 2. Append copyAttribute to copy.
element_copy->append_attribute(name, value); element_copy->append_attribute(verify_cast<Attr>(*copy_attribute));
}); });
if (maybe_exception.has_value())
return *maybe_exception;
copy = move(element_copy); copy = move(element_copy);
} }

9
Tests/LibWeb/Text/expected/wpt-import/dom/nodes/Node-cloneNode-svg.txt Normal file
View file

@ -0,0 +1,9 @@
Harness status: OK
Found 4 tests
4 Pass
Pass cloned <svg> should have the right properties
Pass cloned <svg>'s xmlns:xlink attribute should have the right properties
Pass cloned <use> should have the right properties
Pass cloned <use>'s xlink:href attribute should have the right properties

63
Tests/LibWeb/Text/input/wpt-import/dom/nodes/Node-cloneNode-svg.html Normal file
View file

@ -0,0 +1,63 @@
<!DOCTYPE html>
<meta charset="utf-8">
<title>Cloning of SVG elements and attributes</title>
<link rel="help" href="https://dom.spec.whatwg.org/#dom-node-clonenode">
<link rel="help" href="https://dom.spec.whatwg.org/#concept-node-clone">
<!-- regression test for https://github.com/jsdom/jsdom/issues/1601 -->
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<svg xmlns:xlink='http://www.w3.org/1999/xlink'><use xlink:href='#test'></use></svg>
<script>
"use strict";
const svg = document.querySelector("svg");
const clone = svg.cloneNode(true);
test(() => {
assert_equals(clone.namespaceURI, "http://www.w3.org/2000/svg");
assert_equals(clone.prefix, null);
assert_equals(clone.localName, "svg");
assert_equals(clone.tagName, "svg");
}, "cloned <svg> should have the right properties");
test(() => {
const attr = clone.attributes[0];
assert_equals(attr.namespaceURI, "http://www.w3.org/2000/xmlns/");
assert_equals(attr.prefix, "xmlns");
assert_equals(attr.localName, "xlink");
assert_equals(attr.name, "xmlns:xlink");
assert_equals(attr.value, "http://www.w3.org/1999/xlink");
}, "cloned <svg>'s xmlns:xlink attribute should have the right properties");
test(() => {
const use = clone.firstElementChild;
assert_equals(use.namespaceURI, "http://www.w3.org/2000/svg");
assert_equals(use.prefix, null);
assert_equals(use.localName, "use");
assert_equals(use.tagName, "use");
}, "cloned <use> should have the right properties");
test(() => {
const use = clone.firstElementChild;
const attr = use.attributes[0];
assert_equals(attr.namespaceURI, "http://www.w3.org/1999/xlink");
assert_equals(attr.prefix, "xlink");
assert_equals(attr.localName, "href");
assert_equals(attr.name, "xlink:href");
assert_equals(attr.value, "#test");
}, "cloned <use>'s xlink:href attribute should have the right properties");
</script>