From 1eb581815aa898649b5fca284c37fb8f5073b6a7 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Wed, 2 Jul 2025 13:07:57 +0200 Subject: [PATCH] Tests: Unskip `selection-over-multiple-code-units.html` test The flake was reproducible by running the entire LibWeb test suite over and over again with sanitizers enabled. By making the test async and run at window `load` time instead of document `DOMContentLoaded` time, I've not been able to reproduce the issue locally. Ideally I was able to find the underlying cause for this bug, but for now I'd rather run this regression test. --- Tests/LibWeb/TestConfig.ini | 4 ---- .../selection-over-multiple-code-units.html | 20 ++++++++++--------- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/Tests/LibWeb/TestConfig.ini b/Tests/LibWeb/TestConfig.ini index 11527526822..57b93909d6c 100644 --- a/Tests/LibWeb/TestConfig.ini +++ b/Tests/LibWeb/TestConfig.ini @@ -318,7 +318,3 @@ Text/input/wpt-import/IndexedDB/idbfactory_open.any.html Text/input/XHR/XMLHttpRequest-override-mimetype-blob.html Text/input/wpt-import/webaudio/the-audio-api/the-periodicwave-interface/periodicWave.html - -; Flaky in CI. -; https://github.com/LadybirdBrowser/ladybird/issues/5257 -Text/input/selection-over-multiple-code-units.html diff --git a/Tests/LibWeb/Text/input/selection-over-multiple-code-units.html b/Tests/LibWeb/Text/input/selection-over-multiple-code-units.html index c47050ecf7e..1e249aed92e 100644 --- a/Tests/LibWeb/Text/input/selection-over-multiple-code-units.html +++ b/Tests/LibWeb/Text/input/selection-over-multiple-code-units.html @@ -2,16 +2,18 @@ 😭foobar😭