From 1fbf1bc4ac32d3ffd727fe4e1b6195c94c7dd926 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 9 May 2024 09:48:06 -0400 Subject: [PATCH] LibWeb: Don't try to click a form image until it has loaded We are often trying to click the image before it has finished loading. This results in us trying to click a 0x0 rect. Instead, wait until the image load event. This fixes a flake with form-image-submission.html often seen on CI. --- Tests/LibWeb/Text/input/HTML/form-image-submission.html | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Tests/LibWeb/Text/input/HTML/form-image-submission.html b/Tests/LibWeb/Text/input/HTML/form-image-submission.html index 602f3bc7d23..41cb4599554 100644 --- a/Tests/LibWeb/Text/input/HTML/form-image-submission.html +++ b/Tests/LibWeb/Text/input/HTML/form-image-submission.html @@ -28,7 +28,9 @@ done(); }); - const imageRect = image.getBoundingClientRect(); - internals.click(imageRect.x + 10, imageRect.y + 20); + image.addEventListener("load", () => { + const imageRect = image.getBoundingClientRect(); + internals.click(imageRect.x + 10, imageRect.y + 20); + }); });