mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 20:45:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Meta: Make gn linter actually fail

Browse source 
Without the `--dry-run` flag, the gn linter just formats the files in
place and reports no failure
This commit is contained in:
Totto16 2025-03-05 17:04:03 +01:00 • committed by Jelle Raaijmakers
parent 4c24e0f63d
commit 1fc5744aa4
Notes: github-actions[bot] 2025-03-07 08:45:40 +00:00
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Meta/lint-gn.sh
View file

@ -5,7 +5,7 @@ set -e
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
cd "${script_path}/.." || exit 1
if [ "$#" -eq "0" ]; then
if [ "$#" -eq "0" ] || { [ "$#" -eq "1" ] && [ "--overwrite-inplace" = "$1" ]; }; then
files=()
while IFS= read -r file; do
files+=("$file")
@ -21,12 +21,20 @@ else
done
fi
if (( ${#files[@]} )); then
if ! command -v gn >/dev/null 2>&1 ; then
if ((${#files[@]})); then
if ! command -v gn >/dev/null 2>&1; then
echo "gn is not available, but gn files need linting! Either skip this script, or install gn."
exit 1
fi
gn format "${files[@]}"
gn_args=("--dry-run")
for arg in "$@"; do
if [[ "--overwrite-inplace" = "$arg" ]]; then
gn_args=()
fi
done
gn format "${gn_args[@]}" "${files[@]}"
else
echo "No .gn or .gni files to check."
fi