mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-14 13:01:55 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb/IDB: Improve error messages slightly

Browse source
This commit is contained in:
stelar7 2025-05-08 09:48:06 +02:00 • committed by Sam Atkins
parent 63e1cc7b50
commit 1fe6060ff9
Notes: github-actions[bot] 2025-05-08 13:14:39 +00:00
4 changed files with 15 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View file

@ -960,7 +960,7 @@ WebIDL::ExceptionOr<ErrorOr<JS::Value>> evaluate_key_path_on_a_value(JS::Realm&
else {
// 1. If Type(value) is not Object, return failure.
if (!value.is_object())
return Error::from_string_literal("Value is not an object");
return Error::from_string_literal("Value is not an object during key path evaluation");
auto identifier_property = String::from_utf8_without_validation(identifier.bytes());
@ -969,14 +969,14 @@ WebIDL::ExceptionOr<ErrorOr<JS::Value>> evaluate_key_path_on_a_value(JS::Realm&
// 3. If hop is false, return failure.
if (!hop)
return Error::from_string_literal("Property does not exist");
return Error::from_string_literal("Failed to find property on object during key path evaluation");
// 4. Let value be ! Get(value, identifier).
value = MUST(value.as_object().get(identifier_property));
// 5. If value is undefined, return failure.
if (value.is_undefined())
return Error::from_string_literal("Value is undefined");
return Error::from_string_literal("undefined value on object during key path evaluation");
}
return {};
@ -1229,7 +1229,7 @@ ErrorOr<u64> generate_a_key(GC::Ref<ObjectStore> store)
// 3. If key is greater than 2^53 (9007199254740992), then return failure.
if (key > static_cast<u64>(MAX_KEY_GENERATOR_VALUE))
return Error::from_string_literal("Key is greater than 2^53");
return Error::from_string_literal("Key is greater than 2^53 while trying to generate a key");
// 4. Increase generator’s current number by 1.
generator.increment(1);