From 1ff556a2bd10bd891b7aead777d78fb2c5e606a2 Mon Sep 17 00:00:00 2001 From: Tim Ledbetter Date: Tue, 10 Dec 2024 16:37:43 +0000 Subject: [PATCH] Tests: Move Ladybird specific testdriver code to `testdriver-vendor.js` --- .../input/wpt-import/resources/testdriver-vendor.js | 8 +++++++- .../Text/input/wpt-import/resources/testdriver.js | 12 ++---------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/Tests/LibWeb/Text/input/wpt-import/resources/testdriver-vendor.js b/Tests/LibWeb/Text/input/wpt-import/resources/testdriver-vendor.js index 3e884036363..2496b5f1830 100644 --- a/Tests/LibWeb/Text/input/wpt-import/resources/testdriver-vendor.js +++ b/Tests/LibWeb/Text/input/wpt-import/resources/testdriver-vendor.js @@ -1 +1,7 @@ -// This file intentionally left blank +window.test_driver_internal.get_computed_label = async function(element) { + return await window.internals.getComputedLabel(element); +}; + +window.test_driver_internal.get_computed_role = async function(element) { + return await window.internals.getComputedRole(element); +}; diff --git a/Tests/LibWeb/Text/input/wpt-import/resources/testdriver.js b/Tests/LibWeb/Text/input/wpt-import/resources/testdriver.js index 47a5ec412f6..2d1a89690cc 100644 --- a/Tests/LibWeb/Text/input/wpt-import/resources/testdriver.js +++ b/Tests/LibWeb/Text/input/wpt-import/resources/testdriver.js @@ -233,11 +233,7 @@ * rejected in the cases the WebDriver command errors */ get_computed_label: async function(element) { - // XXX: Ladybird-specific change: Upstream WPT calls - // window.test_driver_internal.get_computed_label(element) here, - // but we’ve changed that to our Ladybird-specific - // window.internals.getComputedLabel(el). - let label = await window.internals.getComputedLabel(element); + let label = await window.test_driver_internal.get_computed_label(element); return label; }, @@ -254,11 +250,7 @@ * rejected in the cases the WebDriver command errors */ get_computed_role: async function(element) { - // XXX: Ladybird-specific change: Upstream WPT calls - // window.test_driver_internal.get_computed_role(element) here, - // but we’ve changed that to our Ladybird-specific - // window.internals.getComputedRole(el). - let role = await window.internals.getComputedRole(element); + let role = await window.test_driver_internal.get_computed_role(element); return role; },