mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 05:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Remove MetalContext from TraversableNavigable

Browse source 
There's no need for TraversableNavigable to keep track of the
MetalContext; our SkiaBackendContext keeps a reference to it.
This commit is contained in:
Jelle Raaijmakers 2025-01-28 10:40:32 +01:00 • committed by Alexander Kalenik
commit 20fbd38b77
Notes: github-actions[bot] 2025-01-31 12:29:46 +00:00
2 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibWeb/HTML/TraversableNavigable.cpp
View file

@ -30,9 +30,9 @@ TraversableNavigable::TraversableNavigable(GC::Ref<Page> page)
{ {
#ifdef AK_OS_MACOS #ifdef AK_OS_MACOS
auto display_list_player_type = page->client().display_list_player_type(); auto display_list_player_type = page->client().display_list_player_type();
if (display_list_player_type == DisplayListPlayerType::SkiaGPUIfAvailable) { if (display_list_player_type == DisplayListPlayerType::SkiaGPUIfAvailable)
m_metal_context = Gfx::get_metal_context(); auto metal_context = Gfx::get_metal_context();
m_skia_backend_context = Gfx::SkiaBackendContext::create_metal_context(*m_metal_context); m_skia_backend_context = Gfx::SkiaBackendContext::create_metal_context(*metal_context);
} }
#endif #endif
@ -1402,7 +1402,7 @@ void TraversableNavigable::paint(DevicePixelRect const& content_rect, Painting::
switch (page().client().display_list_player_type()) { switch (page().client().display_list_player_type()) {
case DisplayListPlayerType::SkiaGPUIfAvailable: { case DisplayListPlayerType::SkiaGPUIfAvailable: {
#ifdef AK_OS_MACOS #ifdef AK_OS_MACOS
if (m_metal_context && m_skia_backend_context && is<Painting::IOSurfaceBackingStore>(target)) { if (m_skia_backend_context && is<Painting::IOSurfaceBackingStore>(target)) {
auto& iosurface_backing_store = static_cast<Painting::IOSurfaceBackingStore&>(target); auto& iosurface_backing_store = static_cast<Painting::IOSurfaceBackingStore&>(target);
auto painting_surface = Gfx::PaintingSurface::wrap_iosurface(iosurface_backing_store.iosurface_handle(), *m_skia_backend_context); auto painting_surface = Gfx::PaintingSurface::wrap_iosurface(iosurface_backing_store.iosurface_handle(), *m_skia_backend_context);
Painting::DisplayListPlayerSkia player(*m_skia_backend_context, painting_surface); Painting::DisplayListPlayerSkia player(*m_skia_backend_context, painting_surface);

4
Libraries/LibWeb/HTML/TraversableNavigable.h
View file

@ -155,10 +155,6 @@ private:
String m_window_handle; String m_window_handle;
RefPtr<Gfx::SkiaBackendContext> m_skia_backend_context; RefPtr<Gfx::SkiaBackendContext> m_skia_backend_context;
#ifdef AK_OS_MACOS
RefPtr<Gfx::MetalContext> m_metal_context;
#endif
}; };
struct BrowsingContextAndDocument { struct BrowsingContextAndDocument {