mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 13:49:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use parent's available space for anonymous blocks in BFC

Browse source 
Height resolution assumes that when available space is definite, it
matches the size of non-anonymous containing block. With this change, we
correctly maintain this assumption when box is wrapped in anonymous
node.

Fixes https://github.com/LadybirdBrowser/ladybird/issues/3422
This commit is contained in:
Aliaksandr Kalenik 2025-03-15 03:46:09 +01:00 • committed by Alexander Kalenik
commit 227b4c38b7
Notes: github-actions[bot] 2025-03-15 12:52:21 +00:00
3 changed files with 47 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -803,7 +803,8 @@ void BlockFormattingContext::layout_block_level_box(Box const& box, BlockContain
});
}
layout_block_level_children(as<BlockContainer>(box), box_state.available_inner_space_or_constraints_from(available_space));
auto space_available_for_children = box.is_anonymous() ? available_space : box_state.available_inner_space_or_constraints_from(available_space);
layout_block_level_children(as<BlockContainer>(box), space_available_for_children);
}
}

29
Tests/LibWeb/Layout/expected/block-and-inline/box-with-percentage-height-wrapped-in-anonymous.txt Normal file
View file

@ -0,0 +1,29 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x116 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x100 children: not-inline
BlockContainer <div.outer> at (8,8) content-size 100x100 children: not-inline
BlockContainer <(anonymous)> at (8,8) content-size 100x17 children: inline
InlineNode <div.inline>
frag 0 from TextNode start: 0, length: 1, rect: [8,8 9.34375x17] baseline: 13.296875
"a"
TextNode <#text>
BlockContainer <(anonymous)> at (8,25) content-size 100x100 children: not-inline continuation
BlockContainer <div.inner> at (8,25) content-size 100x100 children: not-inline
BlockContainer <(anonymous)> at (8,125) content-size 100x17 children: inline
InlineNode <div.inline> continuation
frag 0 from TextNode start: 0, length: 1, rect: [8,125 9.46875x17] baseline: 13.296875
"b"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x116] overflow: [0,0 800x142]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x100] overflow: [8,8 784x134]
PaintableWithLines (BlockContainer<DIV>.outer) [8,8 100x100] overflow: [8,8 100x134]
PaintableWithLines (BlockContainer(anonymous)) [8,8 100x17]
PaintableWithLines (InlineNode<DIV>.inline)
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer(anonymous)) [8,25 100x100]
PaintableWithLines (BlockContainer<DIV>.inner) [8,25 100x100]
PaintableWithLines (BlockContainer(anonymous)) [8,125 100x17]
PaintableWithLines (InlineNode<DIV>.inline)
TextPaintable (TextNode<#text>)

16
Tests/LibWeb/Layout/input/block-and-inline/box-with-percentage-height-wrapped-in-anonymous.html Normal file
View file

@ -0,0 +1,16 @@
<!doctype html><html><head><style>
.outer {
width: 100px;
height: 100px;
background-color: red;
}
.inner {
background-color: green;
height: 100%;
width: 100%;
display: block;
}
.inline {
display: inline;
}
</style></head><body><div class="outer"><div class="inline">a<div class="inner"></div>b</div>