mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-23 09:22:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Track if element was created from token with dupe attributes

Browse source 
This is required for CSP to ignore the nonce attribute to prevent
duplicate attributes hijacking the attribute.

See https://w3c.github.io/webappsec-csp/#security-nonce-hijacking
This commit is contained in:
Luke Wilde 2024-12-02 12:33:52 +00:00 • committed by Andrew Kaster
parent b6b030aa43
commit 2368641de5
Notes: github-actions[bot] 2025-07-09 21:54:13 +00:00
5 changed files with 27 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/HTML/Parser/HTMLToken.h
View file

@ -328,6 +328,7 @@ public:
void set_end_position(Badge<HTMLTokenizer>, Position end_position) { m_end_position = end_position; }
void normalize_attributes();
bool had_duplicate_attribute() const { return m_had_duplicate_attribute; }
private:
Vector<Attribute> const* tag_attributes() const
@ -355,6 +356,11 @@ private:
bool m_tag_self_closing { false };
bool m_tag_self_closing_acknowledged { false };
// AD-HOC: We need to know if the token had duplicate attributes, as Content Security Policy disables the nonce
// attribute on the element that will be created from such a token.
// https://w3c.github.io/webappsec-csp/#is-element-nonceable
bool m_had_duplicate_attribute { false };
// Type::StartTag and Type::EndTag (tag name)
FlyString m_string_data;