mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-09 01:29:17 +00:00
LibWeb: Track if element was created from token with dupe attributes
This is required for CSP to ignore the nonce attribute to prevent duplicate attributes hijacking the attribute. See https://w3c.github.io/webappsec-csp/#security-nonce-hijacking
This commit is contained in:
parent
b6b030aa43
commit
2368641de5
Notes:
github-actions[bot]
2025-07-09 21:54:13 +00:00
Author: https://github.com/Lubrsi
Commit: 2368641de5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5328
Reviewed-by: https://github.com/ADKaster ✅
5 changed files with 27 additions and 0 deletions
|
@ -4067,4 +4067,9 @@ bool Element::should_indicate_focus() const
|
|||
return false;
|
||||
}
|
||||
|
||||
void Element::set_had_duplicate_attribute_during_tokenization(Badge<HTML::HTMLParser>)
|
||||
{
|
||||
m_had_duplicate_attribute_during_tokenization = true;
|
||||
}
|
||||
|
||||
}
|
||||
|
|
|
@ -516,6 +516,9 @@ public:
|
|||
|
||||
virtual bool contributes_a_script_blocking_style_sheet() const { return false; }
|
||||
|
||||
void set_had_duplicate_attribute_during_tokenization(Badge<HTML::HTMLParser>);
|
||||
bool had_duplicate_attribute_during_tokenization() const { return m_had_duplicate_attribute_during_tokenization; }
|
||||
|
||||
protected:
|
||||
Element(Document&, DOM::QualifiedName);
|
||||
virtual void initialize(JS::Realm&) override;
|
||||
|
@ -614,6 +617,13 @@ private:
|
|||
|
||||
size_t m_sibling_invalidation_distance { 0 };
|
||||
|
||||
// https://w3c.github.io/webappsec-csp/#is-element-nonceable
|
||||
// AD-HOC: We need to know the element had a duplicate attribute when it was created from the HTML parser.
|
||||
// However, there currently isn't any specified way to do this, so we store a flag on the token, which is
|
||||
// then passed down to here. This is used by Content Security Policy to disable the nonce attribute if this
|
||||
// flag is set.
|
||||
bool m_had_duplicate_attribute_during_tokenization { false };
|
||||
|
||||
OwnPtr<CSS::CountersSet> m_counters_set;
|
||||
|
||||
// https://drafts.csswg.org/css-contain/#proximity-to-the-viewport
|
||||
|
|
|
@ -816,6 +816,11 @@ GC::Ref<DOM::Element> HTMLParser::create_element_for(HTMLToken const& token, Opt
|
|||
// 9. Let element be the result of creating an element given document, localName, given namespace, null, is, and willExecuteScript.
|
||||
auto element = create_element(*document, local_name, namespace_, {}, is_value, will_execute_script).release_value_but_fixme_should_propagate_errors();
|
||||
|
||||
// AD-HOC: See AD-HOC comment on Element.m_had_duplicate_attribute_during_tokenization about why this is done.
|
||||
if (token.had_duplicate_attribute()) {
|
||||
element->set_had_duplicate_attribute_during_tokenization({});
|
||||
}
|
||||
|
||||
// AD-HOC: Let <link> elements know which document they were originally parsed for.
|
||||
// This is used for the render-blocking logic.
|
||||
if (local_name == HTML::TagNames::link && namespace_ == Namespace::HTML) {
|
||||
|
|
|
@ -98,6 +98,7 @@ void HTMLToken::normalize_attributes()
|
|||
// This is a duplicate attribute, remove it.
|
||||
tag_attributes.remove(i);
|
||||
--i;
|
||||
m_had_duplicate_attribute = true;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -328,6 +328,7 @@ public:
|
|||
void set_end_position(Badge<HTMLTokenizer>, Position end_position) { m_end_position = end_position; }
|
||||
|
||||
void normalize_attributes();
|
||||
bool had_duplicate_attribute() const { return m_had_duplicate_attribute; }
|
||||
|
||||
private:
|
||||
Vector<Attribute> const* tag_attributes() const
|
||||
|
@ -355,6 +356,11 @@ private:
|
|||
bool m_tag_self_closing { false };
|
||||
bool m_tag_self_closing_acknowledged { false };
|
||||
|
||||
// AD-HOC: We need to know if the token had duplicate attributes, as Content Security Policy disables the nonce
|
||||
// attribute on the element that will be created from such a token.
|
||||
// https://w3c.github.io/webappsec-csp/#is-element-nonceable
|
||||
bool m_had_duplicate_attribute { false };
|
||||
|
||||
// Type::StartTag and Type::EndTag (tag name)
|
||||
FlyString m_string_data;
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue