mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 09:39:39 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Rename argument to split_the_parent_of_nodes() to reflect spec

Browse source 
The spec calls it a "node list", not "nodes".
This commit is contained in:
Jelle Raaijmakers 2025-01-09 23:38:53 +01:00 • committed by Andreas Kling
commit 2466021e55
Notes: github-actions[bot] 2025-01-10 22:39:20 +00:00
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibWeb/Editing/Internal/Algorithms.cpp
View file

@ -2434,13 +2434,13 @@ Optional<String> specified_command_value(GC::Ref<DOM::Element> element, FlyStrin
} }
// https://w3c.github.io/editing/docs/execCommand/#split-the-parent // https://w3c.github.io/editing/docs/execCommand/#split-the-parent
void split_the_parent_of_nodes(Vector<GC::Ref<DOM::Node>> const& nodes) void split_the_parent_of_nodes(Vector<GC::Ref<DOM::Node>> const& node_list)
{ {
VERIFY(nodes.size() > 0); VERIFY(!node_list.is_empty());
// 1. Let original parent be the parent of the first member of node list. // 1. Let original parent be the parent of the first member of node list.
GC::Ref<DOM::Node> first_node = *nodes.first(); GC::Ref<DOM::Node> first_node = *node_list.first();
GC::Ref<DOM::Node> last_node = *nodes.last(); GC::Ref<DOM::Node> last_node = *node_list.last();
GC::Ref<DOM::Node> original_parent = *first_node->parent(); GC::Ref<DOM::Node> original_parent = *first_node->parent();
// 2. If original parent is not editable or its parent is null, do nothing and abort these // 2. If original parent is not editable or its parent is null, do nothing and abort these
@ -2451,7 +2451,7 @@ void split_the_parent_of_nodes(Vector<GC::Ref<DOM::Node>> const& nodes)
// 3. If the first child of original parent is in node list, remove extraneous line breaks // 3. If the first child of original parent is in node list, remove extraneous line breaks
// before original parent. // before original parent.
GC::Ref<DOM::Node> first_child = *original_parent->first_child(); GC::Ref<DOM::Node> first_child = *original_parent->first_child();
auto first_child_in_nodes_list = nodes.contains_slow(first_child); auto first_child_in_nodes_list = node_list.contains_slow(first_child);
if (first_child_in_nodes_list) if (first_child_in_nodes_list)
remove_extraneous_line_breaks_before_node(original_parent); remove_extraneous_line_breaks_before_node(original_parent);
@ -2462,7 +2462,7 @@ void split_the_parent_of_nodes(Vector<GC::Ref<DOM::Node>> const& nodes)
// 5. If the last child of original parent is in node list, and original parent precedes a line // 5. If the last child of original parent is in node list, and original parent precedes a line
// break, set precedes line break to true. Otherwise, set precedes line break to false. // break, set precedes line break to true. Otherwise, set precedes line break to false.
GC::Ref<DOM::Node> last_child = *original_parent->last_child(); GC::Ref<DOM::Node> last_child = *original_parent->last_child();
bool last_child_in_nodes_list = nodes.contains_slow(last_child); bool last_child_in_nodes_list = node_list.contains_slow(last_child);
auto precedes_line_break = last_child_in_nodes_list && precedes_a_line_break(original_parent); auto precedes_line_break = last_child_in_nodes_list && precedes_a_line_break(original_parent);
// 6. If the first child of original parent is not in node list, but its last child is: // 6. If the first child of original parent is not in node list, but its last child is:
@ -2472,7 +2472,7 @@ void split_the_parent_of_nodes(Vector<GC::Ref<DOM::Node>> const& nodes)
if (!first_child_in_nodes_list && last_child_in_nodes_list) { if (!first_child_in_nodes_list && last_child_in_nodes_list) {
// 1. For each node in node list, in reverse order, insert node into the parent of original // 1. For each node in node list, in reverse order, insert node into the parent of original
// parent immediately after original parent, preserving ranges. // parent immediately after original parent, preserving ranges.
for (auto node : nodes.in_reverse()) for (auto node : node_list.in_reverse())
move_node_preserving_ranges(node, parent_of_original_parent, original_parent_index + 1); move_node_preserving_ranges(node, parent_of_original_parent, original_parent_index + 1);
// 2. If precedes line break is true, and the last member of node list does not precede a // 2. If precedes line break is true, and the last member of node list does not precede a
@ -2512,7 +2512,7 @@ void split_the_parent_of_nodes(Vector<GC::Ref<DOM::Node>> const& nodes)
// 8. For each node in node list, insert node into the parent of original parent immediately // 8. For each node in node list, insert node into the parent of original parent immediately
// before original parent, preserving ranges. // before original parent, preserving ranges.
for (auto node : nodes) for (auto node : node_list)
move_node_preserving_ranges(node, parent_of_original_parent, original_parent_index - 1); move_node_preserving_ranges(node, parent_of_original_parent, original_parent_index - 1);
// 9. If follows line break is true, and the first member of node list does not follow a line // 9. If follows line break is true, and the first member of node list does not follow a line