From 24f97491bf5efb90f8aa5867b3ea3e3367f3396b Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Sun, 3 Sep 2023 23:22:41 +0200 Subject: [PATCH] LibWeb: Delete unused create_a_new_browsing_context_group() Became unused after introducing create_a_new_browsing_context_group_and_document() used in navigables --- .../LibWeb/HTML/BrowsingContextGroup.cpp | 17 ----------------- .../LibWeb/HTML/BrowsingContextGroup.h | 2 -- 2 files changed, 19 deletions(-) diff --git a/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.cpp b/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.cpp index 754f3f3ad0a..c340f1bc73c 100644 --- a/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.cpp +++ b/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.cpp @@ -52,23 +52,6 @@ auto BrowsingContextGroup::create_a_new_browsing_context_group_and_document(Page return BrowsingContextGroupAndDocument { group, document }; } -// https://html.spec.whatwg.org/multipage/browsers.html#creating-a-new-browsing-context-group -JS::NonnullGCPtr BrowsingContextGroup::create_a_new_browsing_context_group(Web::Page& page) -{ - // 1. Let group be a new browsing context group. - // 2. Append group to the user agent's browsing context group set. - auto group = Bindings::main_thread_vm().heap().allocate_without_realm(page); - - // 3. Let browsingContext be the result of creating a new browsing context with null, null, and group. - auto browsing_context = BrowsingContext::create_a_new_browsing_context(page, nullptr, nullptr, *group); - - // 4. Append browsingContext to group. - group->append(move(browsing_context)); - - // 5. Return group. - return *group; -} - // https://html.spec.whatwg.org/multipage/browsers.html#bcg-append void BrowsingContextGroup::append(BrowsingContext& browsing_context) { diff --git a/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.h b/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.h index 3556accefb0..7de8ddd5887 100644 --- a/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.h +++ b/Userland/Libraries/LibWeb/HTML/BrowsingContextGroup.h @@ -18,8 +18,6 @@ class BrowsingContextGroup final : public JS::Cell { JS_CELL(BrowsingContextGroup, JS::Cell); public: - static JS::NonnullGCPtr create_a_new_browsing_context_group(Page&); - struct BrowsingContextGroupAndDocument { JS::NonnullGCPtr browsing_context; JS::NonnullGCPtr document;