From 2516297c865f44c51d09a07001169b08ba430631 Mon Sep 17 00:00:00 2001
From: Sam Atkins <sam@ladybird.org>
Date: Mon, 30 Sep 2024 14:10:27 +0100
Subject: [PATCH] LibWeb/CSS: Return StringStyleValue from parse_string_value()

Callers already relied on this being true, so let's make it contractual.
---
 Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp | 8 ++++----
 Userland/Libraries/LibWeb/CSS/Parser/Parser.h   | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
index ea06233a3ad..a4c2d661de8 100644
--- a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
+++ b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
@@ -3352,7 +3352,7 @@ RefPtr<CSSStyleValue> Parser::parse_counter_value(TokenStream<ComponentValue>& t
 
         TokenStream string_tokens { function_values[1] };
         string_tokens.skip_whitespace();
-        RefPtr<CSSStyleValue> join_string = parse_string_value(string_tokens);
+        auto join_string = parse_string_value(string_tokens);
         string_tokens.skip_whitespace();
         if (!join_string || string_tokens.has_next_token())
             return nullptr;
@@ -3369,7 +3369,7 @@ RefPtr<CSSStyleValue> Parser::parse_counter_value(TokenStream<ComponentValue>& t
         }
 
         transaction.commit();
-        return CounterStyleValue::create_counters(counter_name.release_value(), join_string->as_string().string_value(), counter_style.release_nonnull());
+        return CounterStyleValue::create_counters(counter_name.release_value(), join_string->string_value(), counter_style.release_nonnull());
     }
 
     return nullptr;
@@ -3439,7 +3439,7 @@ RefPtr<CSSStyleValue> Parser::parse_ratio_value(TokenStream<ComponentValue>& tok
     return nullptr;
 }
 
-RefPtr<CSSStyleValue> Parser::parse_string_value(TokenStream<ComponentValue>& tokens)
+RefPtr<StringStyleValue> Parser::parse_string_value(TokenStream<ComponentValue>& tokens)
 {
     auto peek = tokens.peek_token();
     if (peek.is(Token::Type::String)) {
@@ -5471,7 +5471,7 @@ RefPtr<CSSStyleValue> Parser::parse_font_language_override_value(TokenStream<Com
         auto transaction = tokens.begin_transaction();
         tokens.skip_whitespace();
         if (auto string = parse_string_value(tokens)) {
-            auto string_value = string->as_string().string_value();
+            auto string_value = string->string_value();
             tokens.skip_whitespace();
             if (tokens.has_next_token()) {
                 dbgln_if(CSS_PARSER_DEBUG, "CSSParser: Failed to parse font-language-override: unexpected trailing tokens");
diff --git a/Userland/Libraries/LibWeb/CSS/Parser/Parser.h b/Userland/Libraries/LibWeb/CSS/Parser/Parser.h
index 58bd47b89cc..1b2c45c6315 100644
--- a/Userland/Libraries/LibWeb/CSS/Parser/Parser.h
+++ b/Userland/Libraries/LibWeb/CSS/Parser/Parser.h
@@ -256,7 +256,7 @@ private:
     RefPtr<CSSStyleValue> parse_counter_definitions_value(TokenStream<ComponentValue>&, AllowReversed, i32 default_value_if_not_reversed);
     RefPtr<CSSStyleValue> parse_rect_value(TokenStream<ComponentValue>&);
     RefPtr<CSSStyleValue> parse_ratio_value(TokenStream<ComponentValue>&);
-    RefPtr<CSSStyleValue> parse_string_value(TokenStream<ComponentValue>&);
+    RefPtr<StringStyleValue> parse_string_value(TokenStream<ComponentValue>&);
     RefPtr<CSSStyleValue> parse_image_value(TokenStream<ComponentValue>&);
     RefPtr<CSSStyleValue> parse_paint_value(TokenStream<ComponentValue>&);
     enum class PositionParsingMode {