From 25c22bb5e5e5ab5e0fd60ee43a039064b54963ec Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 18 Mar 2024 16:01:47 +0100 Subject: [PATCH] LibWeb: Reorder MatchingRule members to make it smaller By packing the members more efficiently, it goes from 64 to 56 bytes. --- Userland/Libraries/LibWeb/CSS/StyleComputer.cpp | 4 ++-- Userland/Libraries/LibWeb/CSS/StyleComputer.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp b/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp index a86106b535f..7e95665eeff 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp +++ b/Userland/Libraries/LibWeb/CSS/StyleComputer.cpp @@ -2323,14 +2323,14 @@ NonnullOwnPtr StyleComputer::make_rule_cache_for_casca size_t selector_index = 0; for (CSS::Selector const& selector : rule.selectors()) { MatchingRule matching_rule { - cascade_origin, shadow_root, &rule, sheet, style_sheet_index, rule_index, selector_index, - selector.specificity() + selector.specificity(), + cascade_origin, }; for (auto const& simple_selector : selector.compound_selectors().last().simple_selectors) { diff --git a/Userland/Libraries/LibWeb/CSS/StyleComputer.h b/Userland/Libraries/LibWeb/CSS/StyleComputer.h index 2b482bafa22..8d0a7001c53 100644 --- a/Userland/Libraries/LibWeb/CSS/StyleComputer.h +++ b/Userland/Libraries/LibWeb/CSS/StyleComputer.h @@ -21,7 +21,7 @@ namespace Web::CSS { // https://www.w3.org/TR/css-cascade/#origin -enum class CascadeOrigin { +enum class CascadeOrigin : u8 { Author, User, UserAgent, @@ -30,7 +30,6 @@ enum class CascadeOrigin { }; struct MatchingRule { - CascadeOrigin cascade_origin; JS::GCPtr shadow_root; JS::GCPtr rule; JS::GCPtr sheet; @@ -39,6 +38,7 @@ struct MatchingRule { size_t selector_index { 0 }; u32 specificity { 0 }; + CascadeOrigin cascade_origin; bool contains_pseudo_element { false }; bool contains_root_pseudo_class { false }; };