From 260074af8717ae72f7ae48cb0ab17bf8ee9eeddf Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Tue, 1 Oct 2024 11:39:02 +0100 Subject: [PATCH] headless-browser: Ensure test path is always absolute Previously, if you ran with a relative path, then everything would run fine except that the test name would be blank in the output, eg: 1/1234: instead of: 1/1234: Text/input/canvas/export.html --- Userland/Utilities/headless-browser.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Userland/Utilities/headless-browser.cpp b/Userland/Utilities/headless-browser.cpp index 5795d13a966..df06be709fa 100644 --- a/Userland/Utilities/headless-browser.cpp +++ b/Userland/Utilities/headless-browser.cpp @@ -666,6 +666,8 @@ ErrorOr serenity_main(Main::Arguments arguments) if (!app->test_dry_run) view = TRY(HeadlessWebContentView::create(move(theme), window_size, app->resources_folder)); + auto absolute_test_root_path = LexicalPath::absolute_path(TRY(FileSystem::current_working_directory()), app->test_root_path); + app->test_root_path = absolute_test_root_path; auto test_glob = ByteString::formatted("*{}*", app->test_glob); return run_tests(view, app->test_root_path, test_glob, app->dump_failed_ref_tests, app->dump_gc_graph, app->test_dry_run); }