mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-22 12:35:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Support Document.onreadystatechange

Browse source 
This is just a standard IDL event attribute handler.

Fixes at least one WPT test:
https://wpt.live/html/dom/documents/resource-metadata-management/document-readyState.html
This commit is contained in:
Andreas Kling 2024-10-08 16:24:23 +02:00 • committed by Andreas Kling
parent de1475f99a
commit 26be8f865a
Notes: github-actions[bot] 2024-10-08 16:50:11 +00:00
5 changed files with 28 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/onreadystatechange.txt Normal file
View file

@ -0,0 +1 @@
interactive

10
Tests/LibWeb/Text/input/HTML/onreadystatechange.html Normal file
View file

@ -0,0 +1,10 @@
<script src="../include.js"></script>
<script>
let readyStates = []
document.onreadystatechange = function() {
readyStates.push(document.readyState);
}
test(() => {
println(readyStates);
});
</script>

10
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -5666,4 +5666,14 @@ Document::StepsToFireBeforeunloadResult Document::steps_to_fire_beforeunload(boo
return { unload_prompt_shown, unload_prompt_canceled };
}
WebIDL::CallbackType* Document::onreadystatechange()
{
return event_handler_attribute(HTML::EventNames::readystatechange);
}
void Document::set_onreadystatechange(WebIDL::CallbackType* value)
{
set_event_handler_attribute(HTML::EventNames::readystatechange, value);
}
}

3
Userland/Libraries/LibWeb/DOM/Document.h
View file

@ -731,6 +731,9 @@ public:
};
StepsToFireBeforeunloadResult steps_to_fire_beforeunload(bool unload_prompt_shown);
[[nodiscard]] WebIDL::CallbackType* onreadystatechange();
void set_onreadystatechange(WebIDL::CallbackType*);
protected:
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;

4
Userland/Libraries/LibWeb/DOM/Document.idl
View file

@ -149,6 +149,10 @@ interface Document : Node {
boolean queryCommandState(DOMString commandId);
boolean queryCommandSupported(DOMString commandId);
DOMString queryCommandValue(DOMString commandId);
// special event handler IDL attributes that only apply to Document objects
[LegacyLenientThis] attribute EventHandler onreadystatechange;
[FIXME] attribute EventHandler onvisibilitychange;
};
dictionary ElementCreationOptions {