mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 01:00:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Replace MarkedVector with Vector in VideoTrackList

Browse source 
There's no need to make the m_video_tracks entries heap roots, we can
visit them instead.
This commit is contained in:
Idan Horowitz 2024-04-05 20:12:44 +03:00 • committed by Andreas Kling
commit 270e0d4b58
Notes: sideshowbarker 2024-07-17 04:01:41 +09:00
4 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/HTML/AudioTrackList.cpp
View file

@ -17,7 +17,6 @@ JS_DEFINE_ALLOCATOR(AudioTrackList);
AudioTrackList::AudioTrackList(JS::Realm& realm)
: DOM::EventTarget(realm, MayInterfereWithIndexedPropertyAccess::Yes)
, m_audio_tracks(realm.heap())
{
}

2
Userland/Libraries/LibWeb/HTML/AudioTrackList.h
View file

@ -52,7 +52,7 @@ private:
virtual void initialize(JS::Realm&) override;
virtual JS::ThrowCompletionOr<Optional<JS::PropertyDescriptor>> internal_get_own_property(JS::PropertyKey const& property_name) const override;
JS::MarkedVector<JS::NonnullGCPtr<AudioTrack>> m_audio_tracks;
Vector<JS::NonnullGCPtr<AudioTrack>> m_audio_tracks;
};
}

7
Userland/Libraries/LibWeb/HTML/VideoTrackList.cpp
View file

@ -127,4 +127,11 @@ WebIDL::CallbackType* VideoTrackList::onremovetrack()
return event_handler_attribute(HTML::EventNames::removetrack);
}
void VideoTrackList::visit_edges(JS::Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
for (auto const& track : m_video_tracks)
visitor.visit(track);
}
}

2
Userland/Libraries/LibWeb/HTML/VideoTrackList.h
View file

@ -42,6 +42,8 @@ public:
private:
explicit VideoTrackList(JS::Realm&);
virtual void visit_edges(Visitor&) override;
virtual void initialize(JS::Realm&) override;
virtual JS::ThrowCompletionOr<Optional<JS::PropertyDescriptor>> internal_get_own_property(JS::PropertyKey const& property_name) const override;