From 273593afba71a42f1d760ac5b6664b77f74ffb7a Mon Sep 17 00:00:00 2001
From: Andreas Kling <andreas@ladybird.org>
Date: Fri, 26 Jul 2024 10:31:19 +0200
Subject: [PATCH] LibWeb: Don't proceed with Element.click() on disabled form
 controls

Fixes an infinite reload loop on some of the dom/events/ tests in WPT.
---
 .../HTML/submit-button-click-when-disabled.txt       |  1 +
 .../HTML/submit-button-click-when-disabled.html      | 12 ++++++++++++
 Userland/Libraries/LibWeb/HTML/HTMLElement.cpp       |  6 +++++-
 3 files changed, 18 insertions(+), 1 deletion(-)
 create mode 100644 Tests/LibWeb/Text/expected/HTML/submit-button-click-when-disabled.txt
 create mode 100644 Tests/LibWeb/Text/input/HTML/submit-button-click-when-disabled.html

diff --git a/Tests/LibWeb/Text/expected/HTML/submit-button-click-when-disabled.txt b/Tests/LibWeb/Text/expected/HTML/submit-button-click-when-disabled.txt
new file mode 100644
index 00000000000..e8f8428f142
--- /dev/null
+++ b/Tests/LibWeb/Text/expected/HTML/submit-button-click-when-disabled.txt
@@ -0,0 +1 @@
+   PASS! Did not click
diff --git a/Tests/LibWeb/Text/input/HTML/submit-button-click-when-disabled.html b/Tests/LibWeb/Text/input/HTML/submit-button-click-when-disabled.html
new file mode 100644
index 00000000000..23068912be9
--- /dev/null
+++ b/Tests/LibWeb/Text/input/HTML/submit-button-click-when-disabled.html
@@ -0,0 +1,12 @@
+<form id="theForm" style="display:none"><button id="theButton" type="submit" disabled></button></form>
+<script src="../include.js"></script>
+<script>
+    theForm.onclick = function() {
+        println("FAIL! Should not click!");
+    }
+
+    test(() => {
+        theButton.click();
+        println("PASS! Did not click");
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp
index 2f4310573da..6ebbf87d772 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp
+++ b/Userland/Libraries/LibWeb/HTML/HTMLElement.cpp
@@ -496,7 +496,11 @@ JS::GCPtr<DOM::NodeList> HTMLElement::labels()
 // https://html.spec.whatwg.org/multipage/interaction.html#dom-click
 void HTMLElement::click()
 {
-    // FIXME: 1. If this element is a form control that is disabled, then return.
+    // 1. If this element is a form control that is disabled, then return.
+    if (auto* form_control = dynamic_cast<FormAssociatedElement*>(this)) {
+        if (!form_control->enabled())
+            return;
+    }
 
     // 2. If this element's click in progress flag is set, then return.
     if (m_click_in_progress)