mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Obtain basename before passing base_url to ClassicScript::create

Browse source 
This would previously crash because it depended on a specific order for
evaluating function arguments, which is undefined.
This commit is contained in:
sin-ack 2024-10-12 11:41:27 +00:00 • committed by Andreas Kling
commit 27b1d94e04
Notes: github-actions[bot] 2024-10-12 13:00:59 +00:00
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/HTML/WindowOrWorkerGlobalScope.cpp
View file

@ -377,7 +377,8 @@ i32 WindowOrWorkerGlobalScopeMixin::run_timer_initialization_steps(TimerHandler
// 7. Let script be the result of creating a classic script given handler, settings object, base URL, and fetch options.
// FIXME: Pass fetch options.
auto script = ClassicScript::create(base_url.basename(), source, settings_object, move(base_url));
auto basename = base_url.basename();
auto script = ClassicScript::create(basename, source, settings_object, move(base_url));
// 8. Run the classic script script.
(void)script->run();