From 27c19c02d2ac75f8979c588f5261343811867322 Mon Sep 17 00:00:00 2001 From: rmg-x Date: Sat, 5 Apr 2025 11:22:50 -0500 Subject: [PATCH] RequestServer: Remove check for square brackets in host before resolving This is no longer needed since `IPv6Address::from_string` supports square brackets. After the update to curl, `CURLOPT_RESOLVE` now supports replacing IPv6 hosts as well. --- Services/RequestServer/ConnectionFromClient.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Services/RequestServer/ConnectionFromClient.cpp b/Services/RequestServer/ConnectionFromClient.cpp index 5525f970bd5..8a686a0932c 100644 --- a/Services/RequestServer/ConnectionFromClient.cpp +++ b/Services/RequestServer/ConnectionFromClient.cpp @@ -376,10 +376,6 @@ void ConnectionFromClient::start_request(i32 request_id, ByteString method, URL: { auto host = url.serialized_host().to_byte_string(); - // Check if host has the bracket notation for IPV6 addresses and remove them - if (host.starts_with("["sv) && host.ends_with("]"sv)) - host = host.substring(1, host.length() - 2); - m_resolver->dns.lookup(host, DNS::Messages::Class::IN, { DNS::Messages::ResourceType::A, DNS::Messages::ResourceType::AAAA }) ->when_rejected([this, request_id](auto const& error) { dbgln("StartRequest: DNS lookup failed: {}", error);