mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-13 20:41:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Do more comprehensive check if next() fast path is possible

Browse source 
Before this change each built-in iterator object has a boolean
`m_next_method_was_redefined`. If user code later changed the iterator’s
prototype (e.g. `Object.setPrototypeOf()`), we still believed the
built-in fast-path was safe and skipped the user supplied override,
producing wrong results.

With this change
`BuiltinIterator::as_builtin_iterator_if_next_is_not_redefined()` looks
up the current `next` property and verifies that it is still the
built-in native function.
This commit is contained in:
Aliaksandr Kalenik 2025-06-01 18:44:18 +02:00 • committed by Alexander Kalenik
parent 0fcb574041
commit 285bc005cb
Notes: github-actions[bot] 2025-06-01 22:16:38 +00:00
25 changed files with 168 additions and 98 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibJS/Runtime/SetIterator.cpp
View file

@ -5,8 +5,8 @@
*/
#include <LibJS/Runtime/Array.h>
#include <LibJS/Runtime/NativeFunction.h>
#include <LibJS/Runtime/SetIterator.h>
#include <LibJS/Runtime/SetIteratorPrototype.h>
namespace JS {
@ -23,8 +23,6 @@ SetIterator::SetIterator(Set& set, Object::PropertyKind iteration_kind, Object&
, m_iteration_kind(iteration_kind)
, m_iterator(static_cast<Set const&>(set).begin())
{
auto& set_iterator_prototype = as<SetIteratorPrototype>(prototype);
m_next_method_was_redefined = set_iterator_prototype.next_method_was_redefined();
}
void SetIterator::visit_edges(Cell::Visitor& visitor)
@ -33,6 +31,19 @@ void SetIterator::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_set);
}
BuiltinIterator* SetIterator::as_builtin_iterator_if_next_is_not_redefined(IteratorRecord const& iterator_record)
{
if (iterator_record.next_method.is_object()) {
auto const& next_function = iterator_record.next_method.as_object();
if (next_function.is_native_function()) {
auto const& native_function = static_cast<NativeFunction const&>(next_function);
if (native_function.is_set_prototype_next_builtin())
return this;
}
}
return nullptr;
}
ThrowCompletionOr<void> SetIterator::next(VM& vm, bool& done, Value& value)
{
if (m_done) {