mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Compute containing block boxes once at start of layout

Browse source 
We now cache the containing block (box) once at the start of layout,
which allows Layout::Node::containing_block() to return instantly
instead of doing tree traversal.

Removes a 0.7% profile item on Speedometer 3.
This commit is contained in:
Andreas Kling 2025-04-18 11:39:23 +02:00 • committed by Andreas Kling
commit 28d564197c
Notes: github-actions[bot] 2025-04-18 23:15:12 +00:00
4 changed files with 32 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/DOM/Document.cpp
View file

@ -1322,6 +1322,11 @@ void Document::update_layout(UpdateLayoutReason reason)
}
}
m_layout_root->for_each_in_inclusive_subtree([&](auto& layout_node) {
layout_node.recompute_containing_block({});
return TraversalDecision::Continue;
});
m_layout_root->for_each_in_inclusive_subtree_of_type<Layout::Box>([&](auto& child) {
if (auto dom_node = child.dom_node(); dom_node && dom_node->is_element()) {
child.set_has_size_containment(as<Element>(*dom_node).has_size_containment());
@ -1338,8 +1343,8 @@ void Document::update_layout(UpdateLayoutReason reason)
m_layout_root->for_each_in_inclusive_subtree_of_type<Layout::Box>([&](auto& child) {
if (!child.is_absolutely_positioned())
return TraversalDecision::Continue;
if (auto* containing_block = child.containing_block()) {
auto* closest_box_that_establishes_formatting_context = containing_block;
if (auto containing_block = child.containing_block()) {
auto closest_box_that_establishes_formatting_context = containing_block;
while (closest_box_that_establishes_formatting_context) {
if (closest_box_that_establishes_formatting_context == m_layout_root)
break;