LibJS: Convert PropertyKey::from_value() to ThrowCompletionOr

Lots of MUST() - perhaps we'll eventually come up with a better API for the common case where it can't fail.
Author: https://github.com/linusg Commit: 29e96eceeb Pull-request: https://github.com/SerenityOS/serenity/pull/11626 Reviewed-by: https://github.com/IdanHo ✅
2025-07-31 13:19:05 +00:00 · 2022-01-04 22:33:30 +01:00 · 2022-01-04 22:33:30 +01:00 · 29e96eceeb · 2024-07-17 21:38:37 +09:00
commit 29e96eceeb
parent 62356cff40
7 changed files with 23 additions and 25 deletions
--- a/Userland/Libraries/LibJS/Runtime/ProxyObject.cpp
+++ b/Userland/Libraries/LibJS/Runtime/ProxyObject.cpp
@ -699,8 +699,10 @@ ThrowCompletionOr<MarkedValueList> ProxyObject::internal_own_property_keys() con

    // 16. For each element key of targetKeys, do
    for (auto& key : target_keys) {
+        auto property_key = MUST(PropertyKey::from_value(global_object, key));
+
        // a. Let desc be ? target.[[GetOwnProperty]](key).
-        auto descriptor = TRY(m_target.internal_get_own_property(PropertyKey::from_value(global_object, key)));
+        auto descriptor = TRY(m_target.internal_get_own_property(property_key));

        // b. If desc is not undefined and desc.[[Configurable]] is false, then
        if (descriptor.has_value() && !*descriptor->configurable) {